[NO-ISSUE] Adding additional DMN examples to the editor #2844
Conversation
Three new examples for the DMN Editor: * Flight Has Capacity * Insurance Pricing * Payroll Signed-off-by: Jason Porter <[email protected]>
LightGuard
changed the title
|
@LightGuard Could you please include screenshots of the added models in Storybook in the PR description? |
|
Payroll: Insurance Pricing: Flight Has Capacity: |
| <text>had previous incidents</text> | ||
| </inputExpression> | ||
| </input> | ||
| <output id="_4612AC80-6FB9-4329-8DA4-DEA3AE628F00" name="Output-1" /> |
There was a problem hiding this comment.
Could we please manually remove this name="Output-1"? it is because of :
| </dmn:decisionService> | ||
| <dmn:decision id="_C49CC255-F44C-4E4E-B5DD-C1F328B692D9" name="compute Payroll"> | ||
| <dmn:extensionElements /> | ||
| <dmn:variable id="_CDD8D60D-065A-450B-80AF-8A4094EB5D9E" name="compute Payroll" typeRef="Any" /> |
| <dmn:itemComponent id="_4A1569B0-D18E-4C7F-BF83-CE48A1E702D0" name="street" isCollection="false"> | ||
| <dmn:typeRef>string</dmn:typeRef> | ||
| </dmn:itemComponent> | ||
| <dmn:itemComponent id="_FA0C1126-BDE1-4DF1-B84F-DA655F1F5E82" name="city" isCollection="false"> | ||
| <dmn:typeRef>string</dmn:typeRef> | ||
| </dmn:itemComponent> | ||
| <dmn:itemComponent id="_5ADF65AB-F8B8-4EA0-ABB5-23EC33C06C4C" name="zipCode" isCollection="false"> | ||
| <dmn:typeRef>string</dmn:typeRef> | ||
| </dmn:itemComponent> |
There was a problem hiding this comment.
the example does not touch these fields, also, we de not demonstrate feature like constraints of data types or similar, do we need to keep them in the example?
similar question for the tEmployee:
- firstname
- lastname
- personalId
- birthDate
There was a problem hiding this comment.
I believe this builds on a tax demo that we have in some other examples, honestly not sure why that one isn't here.
There was a problem hiding this comment.
Thank you for the PR. After a private conversation, here I changes I think we need to address before we proceed with the merge LightGuard#1
Clean up
|
As per private discussion, we're not adding those examples to the StoryBook right now. Thank you though @LightGuard for the effort. |
Three new examples for the DMN Editor: