IGNITE-21445 New implementation for local IndexQuery #11317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-vlsk
changed the title
oleg-vlsk
changed the title
timoninmaxim
requested changes
Apr 26, 2024
...e/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryAdapter.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryAdapter.java
Outdated
Show resolved
Hide resolved
...les/core/src/main/java/org/apache/ignite/internal/processors/cache/IgniteCacheProxyImpl.java
Outdated
Show resolved
Hide resolved
...les/core/src/main/java/org/apache/ignite/internal/processors/cache/IgniteCacheProxyImpl.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryAdapter.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java
Outdated
Show resolved
Hide resolved
timoninmaxim
requested changes
May 2, 2024
...les/core/src/main/java/org/apache/ignite/internal/processors/cache/query/CacheQueryType.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java
Outdated
Show resolved
Hide resolved
…rtition checks added + refactoring
…to one sequence of methods
…l#query(Query, ClusterGroup) + separate methods for local Scan and Index Queries
…tion correction, minor changes
…ording Index Query events added
…s moved to a different patch
…dCacheQueryManager
timoninmaxim
requested changes
May 31, 2024
| } | ||
| }, true); | ||
|
|
||
| return new QueryCursorImpl<>(iter); |
There was a problem hiding this comment.
QueryCursorImpl<> -> QueryCursorImpl there is no any class to inject to the generic.
|
|
||
| Integer part = qry.partition(); | ||
|
|
||
| if (!lostParts.isEmpty()) { |
There was a problem hiding this comment.
This code isn't covered with tests. Let's remove it and add test and code in a separate ticket
There was a problem hiding this comment.
Lost partitions check removed.
| } | ||
| } | ||
|
|
||
| if (qry.nodes().isEmpty()) |
There was a problem hiding this comment.
This code is already starts on local node, why do we need this check?
There was a problem hiding this comment.
The IndexQueryLocalTest#testClientNodeReplicatedCache test (running a local index query on a client node) will fail if we don't do this check and throw a certain exception after it.
| throw new IgniteException(new ClusterGroupEmptyException()); | ||
|
|
||
| if (cctx.deploymentEnabled()) | ||
| cctx.deploy().registerClasses(qry.scanFilter()); |
There was a problem hiding this comment.
This code doesn't covered by tests. For what purpose do you need this code?
| @@ -3427,4 +3503,56 @@ IgniteBiPredicate<K, V> scanFilter() { | |||
| return scanFilter; | |||
| } | |||
| } | |||
|
|
|||
| /** */ | |||
| public static final class IndexQueryIterator<K, V> extends GridCloseableIteratorAdapter<Object> { | |||
There was a problem hiding this comment.
Changed to private.
| return new IndexQueryIterator(idxQryRes.iter()); | ||
| } | ||
| catch (Exception e) { | ||
| throw e; |
There was a problem hiding this comment.
Catch section removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.