Doc: Retypeset the Flink document #7099
Conversation
There was a problem hiding this comment.
Thanks @hililiwei for picking this up! This was long overdue and looks much nicer. I think most of it is good to go since it is mostly moving content. But I think we have to fix the indentation. Also suggested some other small nits.
docs/flink-ddl.md
Outdated
|
|
||
| ### `Create Catalog` | ||
|
|
||
| #### Catalog Configuration |
There was a problem hiding this comment.
Should we split this one out into flink-configuration.md? If you're looking for DDL, you'll first encounter a long list of catalog configuration options.
There was a problem hiding this comment.
Added configuration page.
Co-authored-by: Fokko Driesprong <[email protected]>
Co-authored-by: Fokko Driesprong <[email protected]>
Co-authored-by: Fokko Driesprong <[email protected]>
Co-authored-by: Fokko Driesprong <[email protected]>
Co-authored-by: Fokko Driesprong <[email protected]>
Co-authored-by: Fokko Driesprong <[email protected]>
|
Merging this since there are other PRs affecting the Flink docs as well 👍🏻 Thanks @hililiwei for picking this up, this is a major improvement. |
| @@ -219,103 +221,9 @@ The following properties can be set if using the Hive catalog: | |||
| * `clients`: The Hive metastore client pool size, default value is 2. (Optional) | |||
| * `warehouse`: The Hive warehouse location, users should specify this path if neither set the `hive-conf-dir` to specify a location containing a `hive-site.xml` configuration file nor add a correct `hive-site.xml` to classpath. | |||
| * `hive-conf-dir`: Path to a directory containing a `hive-site.xml` configuration file which will be used to provide custom Hive configuration values. The value of `hive.metastore.warehouse.dir` from `<hive-conf-dir>/hive-site.xml` (or hive configure file from classpath) will be overwritten with the `warehouse` value if setting both `hive-conf-dir` and `warehouse` when creating iceberg catalog. | |||
| * `hadoop-conf-dir`: Path to a directory containing `core-site.xml` and `hdfs-site.xml` configuration files which will be used to provide custom Hadoop configuration values. | |||
| * `hadoop-conf-dir`: Path to a directory containing `core-site.xml` and `hdfs-site.xml` configuration files which will be used to provide custom Hadoop configuration values. | |||
There was a problem hiding this comment.
why is the hive catalog section not completely removed here?
There was a problem hiding this comment.
My intention was to keep a sample catalog so that readers could quickly use it to create tables. If hive-catalog is removed, readers may be confused about how to create a working catalog.
|
thank you guys, @Fokko @stevenzwu . |
Retypeset the Flink document,.
#7099
apache/iceberg-docs#207