fix: ValueWriters.FixedByteBufferWriter should use writeFixed(), not writeBytes() [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] - #17507
Open
waterWang wants to merge 1 commit into
Conversation
uros-b
reviewed
Aug 4, 2026
uros-b
left a comment
Member
There was a problem hiding this comment.
@waterWang Please note that this may have already been covered in #17502. cc @DuanRuixiao
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For Avro
fixed[N]fields, the encoder must write fixed-length datawithout a length prefix.
writeBytes()writes a length-prefixed bytesvalue, which corrupts the Avro binary encoding for
fixed[N]schema.Fix
Replace
encoder.writeBytes(bytes)with the correct fixed-length write:Testing
Preconditions.checkArgumentvalidatesbytes.remaining() == lengthbefore the writeduplicate()creates a view so the original buffer's position is not modifiedFixes #17501