Skip to content

Convert VARIANT to binary placeholder#15228

Open
mrendi29 wants to merge 4 commits intoapache:mainfrom
mrendi29:hms-variant-bug
Open

Convert VARIANT to binary placeholder#15228
mrendi29 wants to merge 4 commits intoapache:mainfrom
mrendi29:hms-variant-bug

Conversation

@mrendi29
Copy link

@mrendi29 mrendi29 commented Feb 3, 2026

Fixes #15220

@github-actions github-actions bot added the hive label Feb 3, 2026
@mrendi29
Copy link
Author

mrendi29 commented Feb 3, 2026

cc @RussellSpitzer

Copy link
Member

@RussellSpitzer RussellSpitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right fix, although I believe we should document it. Another approach (if we are worried about this conversion) is to go to the actual caller of this code and just strip out variants before we pass in the schema. Since I don't think we actually use this hive schema anywhere for reads it's probably fine to just use a placeholder.

As @pvary noted we also have to take care of the other non-compatible types, (nanos) that will break this code.

I do want to make sure we get at least one Hive Integration expert to make sure we aren't breaking anything by doing this. (Since technically this will be a struct)

@mrendi29
Copy link
Author

mrendi29 commented Feb 3, 2026

As @pvary noted we also have to take care of the other non-compatible types, (nanos) that will break this code.

I am happy to open a new PR (or even do it as part of the same PR ) to address that once the community agrees overall that this is the correct approach.

I'll also update the docs to reflect this change shortly

@pvary
Copy link
Contributor

pvary commented Feb 4, 2026

CC: @deniskuzZ
I would like to hear from the Apache Hive team on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VARIANT does not work with HMS

5 participants