Docs: Remove data_file.distinct_counts #12183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Specification
Fokko
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Thanks @jacobmarble for raising this. This should have happened a while ago to avoid unnecessary confusion.
No worries! The Iceberg spec is not perfect, but it's one of the better ones out there, so it's a pleasure to help where we can! |
Looking at this made me realize I had a similar PR a year ago. It may have slipped through. |
nastra
reviewed
Feb 6, 2025
| @@ -587,32 +587,31 @@ The schema of a manifest file is a struct called `manifest_entry` with the follo | |||
|
|
|||
| `data_file` is a struct with the following fields: | |||
|
|
|||
| | v1 | v2 | v3 | Field id, name | Type | Description | | |||
There was a problem hiding this comment.
can we please make this change without updating the entire table?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #767
data_file.distinct_countswas deprecated about four years ago.Furthermore:
data_fileAvro objects containing this field, and will not be fixed.This PR removes the field. If deprecation is preferred, then please see #12182.