Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Hive: close the fileIO client when closing the hive catalog" #11858

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Dec 23, 2024

This reverts commit 7e2920a from #10771.

Issue reported in #11783, #11633 and #11582.

I was able to reproduce this on PyIceberg apache/iceberg-python#1323, and while doing a git bisect, this led me to this PR:

➜  iceberg git:(7e2920af4) git bisect bad       
7e2920af400e5d559f8f1742b1043787b0477d74 is the first bad commit
commit 7e2920af400e5d559f8f1742b1043787b0477d74
Author: Hussein Awala <[email protected]>
Date:   Thu Jul 25 19:50:19 2024 +0200

    Hive: close the fileIO client when closing the hive catalog (#10771)
    
    Co-authored-by: Amogh Jahagirdar <[email protected]>
    Co-authored-by: Eduard Tudenhoefner <[email protected]>

 .../java/org/apache/iceberg/hive/HiveCatalog.java  | 33 +++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)

For now, I suggest reverting it to backport this to 1.7.2.

Closes #11783
Closes #11633

cc @hussein-awala @nastra @amogh-jahagirdar

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the revert. I will try to find out why he introduced this bug.

Thanks @Fokko!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants