Remove unneeded metadata read during update event generation #11829
+48
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantatspothero
force-pushed
the
gn/removeUnneededMetadataReadUpdateEvent
branch
2 times, most recently
from
ad81312 to
28984fe
Compare
grantatspothero
commented
Dec 19, 2024
| @@ -475,10 +475,14 @@ public void commit() { | |||
| } | |||
| } | |||
|
|
|||
| Object updateEvent(Snapshot committedSnapshot) { | |||
There was a problem hiding this comment.
PendingUpdate.updateEvent only usage is in SnapshotProducer currently so could change the interface directly to updateEvent(Snapshot committedSnapshot), but did not want to make a backwards incompatible API change
The whole update event/listener functionality seems untouched for years.
grantatspothero
force-pushed
the
gn/removeUnneededMetadataReadUpdateEvent
branch
from
28984fe to
a710e1c
Compare
avoids unnecessary iceberg metadata read of just committed snapshot
grantatspothero
force-pushed
the
gn/removeUnneededMetadataReadUpdateEvent
branch
from
a710e1c to
072bacf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from this PR:
#10523
The above PR removed unnecessary objectstore reads after commit, but there was 1 I missed.
SnapshotProducer.notifyListenershas the same problem of reading metadata from objectstore instead of just reading the in memory committed Snapshot object.