Flink: Avoid RANGE mode broken chain when write parallelism changes #11702
+35
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pvary @stevenzwu Can you help me review it if you have time? Thanks a lot |
|
@huyuanfeng2018: Could we have a unit test for this to avoid future regressions? |
|
Thanks @pvary and @mxm review~
done. @stevenzwu cc, Maybe you will be interested in this~ |
huyuanfeng2018
force-pushed
the
fix-broken-chain
branch
from
f2fed06 to
61f4c6f
Compare
stevenzwu
reviewed
Dec 23, 2024
| out.collect(statisticsOrRecord.record()); | ||
| } | ||
| }) | ||
| // Set the parallelism same as writerParallelism avoid broken chain |
There was a problem hiding this comment.
nit: maybe this?
Set the parallelism same as writerParallelism to promote operator chaining with the downstream writer operator.
fixed. PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed： #11543
This fix will modify the data processing process in RANGE mode, set the filter link of
StatisticsOrRecordand actively set it towriteParallelismto avoid the shuffle mode changing to rebalance due to changes in parallelism in subsequent write operators.