Closed
Conversation
Contributor
Author
|
I changed my mind here; I don't think we want to deprecate this. The problem is when you add/drop a whole manifest, the snapshot summary becomes corrupt. You don't know how many files are dropped/added when you drop the file manifest. I think it would make more sense to keep track of this at the manifest-list level, so we can drop the manifest without having to open it and go through it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding manifests produces invalid summaries and I don't think that's a good practice. This PR deprecates the method (which simplifies
MergingSnapshotProducer).The method is mostly used in tests and when importing a table in Spark. If we agree to remove this, we can see how we can scale out the writing of the manifests.