Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mmhash3 v4 #420

Closed
wants to merge 1 commit into from
Closed

Allow mmhash3 v4 #420

wants to merge 1 commit into from

Conversation

jonashaag
Copy link
Contributor

Let's give this a try.

Unblocks Python 3.12 support on conda-forge

@Fokko
Copy link
Contributor

Fokko commented Feb 13, 2024

I'm actually the maintainer of mmhash3, I forked it to support Python 3.11

@@ -47,11 +47,11 @@ include = [

[tool.poetry.dependencies]
python = "^3.8"
mmhash3 = ">=3.0.0,<4.0.0"
mmhash3 = ">=3.0.0,<5.0.0"
Copy link
Contributor

@Fokko Fokko Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So mmhash3 is my forked version: https://github.com/Fokko/mmhash3/

We can go back to the original mmh3: https://github.com/hajimes/mmh3/

Suggested change
mmhash3 = ">=3.0.0,<5.0.0"
mmh3 = ">=4.0.0,<5.0.0"

After this change, you have to run poetry update to generate the lock file.

@Fokko
Copy link
Contributor

Fokko commented Mar 14, 2024

Thanks for the PR @jonashaag, this has been resolved in #460

@Fokko Fokko closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants