Allow mmhash3 v4 #420
Closed
Allow mmhash3 v4 #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm actually the maintainer of |
Fokko
reviewed
Feb 21, 2024
| @@ -47,11 +47,11 @@ include = [ | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = "^3.8" | |||
| mmhash3 = ">=3.0.0,<4.0.0" | |||
| mmhash3 = ">=3.0.0,<5.0.0" | |||
There was a problem hiding this comment.
So mmhash3 is my forked version: https://github.com/Fokko/mmhash3/
We can go back to the original mmh3: https://github.com/hajimes/mmh3/
Suggested change
| mmhash3 = ">=3.0.0,<5.0.0" | |
| mmh3 = ">=4.0.0,<5.0.0" |
After this change, you have to run poetry update to generate the lock file.
|
Thanks for the PR @jonashaag, this has been resolved in #460 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's give this a try.
Unblocks Python 3.12 support on conda-forge