Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support python 3.12 #254

Closed
wants to merge 4 commits into from
Closed

Conversation

MehulBatra
Copy link
Contributor

@MehulBatra MehulBatra commented Jan 7, 2024

  1. ray seems to be a blocker as they do not support python3.12 as of now
image

[Open Ticket for Ray 3.12 Support] (ray-project/ray#40211)

  1. duckdb doesn't support 3.12 and still has a build mechanism via distutils
  • Tentative release for Duckdb supporting 3.12 is 29Jan, Version 0.10
image
  1. Dual version dependency for numpy to support 3.12,

  2. Upgraded greenlet to 3.0.3 to support Python 3.12, with dual dependency

  3. python 3.12 no longer supports distutils PEP632, we need to upgrade packages that get installed with support of PEP517 builds

@MehulBatra MehulBatra changed the title bump greenlet, numpy, remove support for 3.8 support python 3.12 Jan 8, 2024
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@cclauss
Copy link

cclauss commented Jan 13, 2024

Similar to

@Fokko Can you please approve the workflow run so we can see the results of the tests?

pyproject.toml Outdated Show resolved Hide resolved
@Fokko
Copy link
Contributor

Fokko commented Mar 13, 2024

@MehulBatra can you rebase?

@MehulBatra
Copy link
Contributor Author

@MehulBatra can you rebase?

rebased it but It will still fail for 3.12 due to ray support, I am keeping a close eye on it.

@MehulBatra
Copy link
Contributor Author

Tentative ray support for 3.12 -> ray-project/ray#40211 (comment)

@MehulBatra
Copy link
Contributor Author

PR being worked on for Ray 3.12: ray-project/ray#45477

@pdpark
Copy link

pdpark commented Jun 4, 2024

FYI: Ray issue 45477 was recently completed.

@MehulBatra
Copy link
Contributor Author

FYI: Ray issue 45477 was recently completed.

Thank you so much for the update! @pdpark
Soon there will be a release too I believe (will keep an eye on the same), and then we can hit the road!

@MehulBatra MehulBatra force-pushed the support_python312 branch from 97f713e to 996eee5 Compare July 1, 2024 12:32
@MehulBatra
Copy link
Contributor Author

@Fokko could you please run the CI/CD

@Fokko
Copy link
Contributor

Fokko commented Jul 1, 2024

@MehulBatra Certainly! How do you feel like splitting the strtobool into a separate PR? I think it would be good to already have that in to enable Python 3.12 support with engines other than Ray.

@MehulBatra
Copy link
Contributor Author

@MehulBatra Certainly! How do you feel like splitting the strtobool into a separate PR? I think it would be good to already have that in to enable Python 3.12 support with engines other than Ray.

That makes sense, I will raise separate PR for the same.

@MehulBatra
Copy link
Contributor Author

@Fokko I have separated the strtobool in a separate PR, please have a look
#880

@cclauss
Copy link

cclauss commented Jul 2, 2024

pytest is kicking out a bunch of warnings that someone should be investigating.

Python 3.13 is in beta 3 so should testing be started on it as well? https://www.python.org/download/pre-releases

@Jiafi
Copy link

Jiafi commented Aug 29, 2024

looks like the next release of ray should hopefully have 3.12 support

@cclauss
Copy link

cclauss commented Aug 29, 2024

Cool! Python 3.13 is scheduled to be released on October 1st.

@kevinjqliu
Copy link
Contributor

hey @MehulBatra, can i close this in favor of #1068?

@MehulBatra
Copy link
Contributor Author

hey @MehulBatra, can i close this in favor of #1068?

yes please go ahead @kevinjqliu

@kevinjqliu kevinjqliu closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants