-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support python 3.12 #254
support python 3.12 #254
Conversation
Similar to @Fokko Can you please approve the workflow run so we can see the results of the tests? |
@MehulBatra can you rebase? |
rebased it but It will still fail for 3.12 due to ray support, I am keeping a close eye on it. |
Tentative ray support for 3.12 -> ray-project/ray#40211 (comment) |
PR being worked on for Ray 3.12: ray-project/ray#45477 |
FYI: Ray issue 45477 was recently completed. |
Thank you so much for the update! @pdpark |
Co-authored-by: Christian Clauss <[email protected]>
97f713e
to
996eee5
Compare
@Fokko could you please run the CI/CD |
@MehulBatra Certainly! How do you feel like splitting the |
That makes sense, I will raise separate PR for the same. |
pytest is kicking out a bunch of warnings that someone should be investigating. Python 3.13 is in beta 3 so should testing be started on it as well? https://www.python.org/download/pre-releases |
looks like the next release of ray should hopefully have 3.12 support |
Cool! Python 3.13 is scheduled to be released on October 1st. |
hey @MehulBatra, can i close this in favor of #1068? |
yes please go ahead @kevinjqliu |
ray
seems to be a blocker as they do not support python3.12 as of now[Open Ticket for Ray 3.12 Support] (ray-project/ray#40211)
duckdb
doesn't support 3.12 and still has a build mechanism via distutilsDual version dependency for
numpy
to support 3.12,Upgraded
greenlet
to 3.0.3 to support Python 3.12, with dual dependencypython 3.12 no longer supports distutils PEP632, we need to upgrade packages that get installed with support of PEP517 builds