Accept date in literal #1618

TennyZhuang · 2025-02-06T10:32:47Z

No description provided.

Fokko · 2025-02-06T14:59:52Z

pyiceberg/expressions/literals.py

@@ -149,6 +150,8 @@ def literal(value: L) -> Literal[L]:
        return DecimalLiteral(value)
    elif isinstance(value, datetime):
        return TimestampLiteral(datetime_to_micros(value))  # type: ignore
+    elif isinstance(value, date):
+        return DateLiteral(date_to_days(value))


Suggested change

return DateLiteral(date_to_days(value))

return DateLiteral(date_to_days(value)) # type: ignore

kevinjqliu

Thanks for the PR! Looks like theres a CI issue, Fokko's suggestion might help resolve it.

Could you also add a test for this change? heres an example for TimestampLiteral

iceberg-python/tests/expressions/test_literals.py

Lines 909 to 910 in dfbee4b

    
           def test_literal_from_datetime() -> None: 
        
               assert isinstance(literal(datetime.datetime.now()), TimestampLiteral)

Accept date in literal

146dad5

Fokko reviewed Feb 6, 2025

View reviewed changes

kevinjqliu reviewed Feb 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Accept date in literal #1618

Accept date in literal #1618

TennyZhuang commented Feb 6, 2025

Fokko Feb 6, 2025

kevinjqliu left a comment

	return DateLiteral(date_to_days(value))
	return DateLiteral(date_to_days(value)) # type: ignore

	def test_literal_from_datetime() -> None:
	assert isinstance(literal(datetime.datetime.now()), TimestampLiteral)

Accept date in literal #1618

Are you sure you want to change the base?

Accept date in literal #1618

Conversation

TennyZhuang commented Feb 6, 2025

Fokko Feb 6, 2025

Choose a reason for hiding this comment

kevinjqliu left a comment

Choose a reason for hiding this comment