Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base headers in properties to signer_headers #1610

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tom-s-powell
Copy link

Include the headers defined in properties in the signer_headers. This is consistent with the behaviour of the default Java AWS signer: https://github.com/apache/iceberg/blob/e406e3db80d1735fe6c840ce99ecc300ae1dd763/aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java#L345. The headers in the auth session include the "base headers" which are those obtained from the catalog properties.

@Fokko
Copy link
Contributor

Fokko commented Feb 5, 2025

Thanks for working on this @tom-s-powell, could you also add this to the documentation: https://github.com/apache/iceberg-python/blob/main/mkdocs/docs/configuration.md#rest-catalog?

properties: Properties,
) -> Properties:
return {
key[len(HEADER_PREFIX):]: value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe pull the len() out of the loop for performance reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants