support all_entries in pyiceberg #1608
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looks like there are a lot of dups in pyiceberg. if you do set and sort, it should match |
|
Thnx @kevinjqliu - wasn't sure how the iceberg java library does it :) |
|
Ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements all_entries metadata table - #1053
This is my initial pr towards supporting all_entries in pyiceberg , i'm currently running into an issue where the number of entries returned by spark is less then what pyiceberg returns and i'm not sure why
pyiceberg results:
spark results:
Im also attaching the csv for investigation puporses
py_iceberg vs spark.csv
*Update - issue resolved