-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] add testpypi nightly build #1601
base: main
Are you sure you want to change the base?
Conversation
ae00205
to
fb47071
Compare
1c34186
to
f833d19
Compare
@Fokko can you take a look at the general flow? I tested in my fork. WYDT about setting the version to |
f833d19
to
3cc5ca1
Compare
|
||
jobs: | ||
set-version: | ||
if: github.repository == 'apache/iceberg-python' # Only run for apache repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verified that workflow is skipped on my forked repo
https://github.com/kevinjqliu/iceberg-python/actions/runs/13123573377
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -35,7 +35,7 @@ jobs: | |||
runs-on: ${{ matrix.os }} | |||
strategy: | |||
matrix: | |||
os: [ ubuntu-22.04, windows-2022, macos-13, macos-14, macos-15 ] | |||
os: [ ubuntu-22.04, windows-2022, macos-13, macos-14 ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's up with macos-15
? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macos-14, macos-15 are the same hardware so produce the same artifacts. i was getting some error uploading to pypi due to
pypi zipfile.BadZipFile: Bad magic number for central directory
removing macos-15 worked 🤷
- name: List downloaded artifacts | ||
run: ls -R dist/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping that we could leave out this kind of debug statements. But it looks like the merge job doesn't mention the actual files: https://github.com/kevinjqliu/iceberg-python/actions/runs/13119881319/job/36603748563
@kevinjqliu This looks great! Thanks for working on it. Very nice how you re-use the build workflow. I left some small comments on how we can maybe simplify manual dispatch, apart from that it looks great. Let me know if you need any help with setting the credential, I think we need to do that through INFRA |
9ecc1ff
to
463d425
Compare
f440cc0
to
d734943
Compare
@Fokko i refactor the code to remove For setting up trusted publisher, its configured on testpypi. I see you're the maintainer for testpypi pyiceberg, the setting is at https://test.pypi.org/manage/project/pyiceberg/settings/publishing/ |
oh i see, only "owner" can make this change (from pypi: This is what it looks like for So we should fill it out for @Fokko can you check if you have permission to do so? otherwise, i can reach out to apache infra |
@kevinjqliu I just bumped you to owner 👍 Let me check why it converts |
oh wait @Fokko i think thats a false alarm. i was looking at a previous run which had the RC in the version. i yanked that one and now its back to normal https://test.pypi.org/project/pyiceberg-kevinliu/ the files also have |
Closes #872
This PR adds the ability to run and publish pypi artifacts nightly to testpypi. It will publish as
pyiceberg
with new version under0.9.0.dev${TIMESTAMP}
, i.e.0.9.0.dev20250206050843
, adhering to PEP440 conversion.Here's a test run on my fork which published to https://test.pypi.org/project/pyiceberg-kevinliu/
This requires setting up Publishing to PyPI with a Trusted Publisher on https://test.pypi.org/ and using example of publishing pyiceberg_core to testpypi
Note, this PR also refactors
.github/workflows/python-release.yml
, i've ran the workflow on my fork and manually verified the version for both pypi and svn artifacts.Setup trusted publisher on testpypi for apache/iceberg-python repo https://test.pypi.org/manage/project/pyiceberg/settings/publishing/