Enable pyiceberg.table.Table.add_files ns downcasting #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fusion2222
force-pushed
the
feature/add-files-ns-downcasting
branch
from
1b715a9 to
e3cab0a
Compare
|
The code linter has failed. Will adjust the code accordingly. |
fusion2222
force-pushed
the
feature/add-files-ns-downcasting
branch
from
e3cab0a to
1a82544
Compare
|
I am a bit stucked... Method The old test had assertion for this warning. However I have no idea why and code does not have sensible comment to explain this and what is the rationale behind it. Is safe to remove / modify it? Some advice from more experienced contributor would be appreciated. |
fusion2222
force-pushed
the
feature/add-files-ns-downcasting
branch
from
c14f08f to
2e65651
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in #1045