Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1045 - Allow downcasting of parquet timestamp[ns] to timestamp[us] for Table.add_files() #1569

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Issue 1045 - Allow downcasting of parquet timestamp[ns] to timestamp[us] for Table.add_files() #1569

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
adde281
See Github issue 1045
lloyd-EA Jan 24, 2025
6a70c91
test_add_files_with_timestamp_tz_ns_fails: changed so that it only fa…
lloyd-EA Jan 27, 2025
bd1d5ad
Linting errors fixed
lloyd-EA Jan 27, 2025
b0f1e7f
value in the comment didn't match
lloyd-EA Jan 27, 2025
d83f858
Check for spark querying "downcasted" ns to us data files
lloyd-EA Jan 28, 2025
3653327
Linting errors fixed
lloyd-EA Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pyiceberg/io/pyarrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2422,6 +2422,7 @@ def _check_pyarrow_schema_compatible(


def parquet_files_to_data_files(io: FileIO, table_metadata: TableMetadata, file_paths: Iterator[str]) -> Iterator[DataFile]:
from pyiceberg.table import DOWNCAST_NS_TIMESTAMP_TO_US_ON_WRITE
for file_path in file_paths:
input_file = io.new_input(file_path)
with input_file.open() as input_stream:
Expand All @@ -2432,7 +2433,12 @@ def parquet_files_to_data_files(io: FileIO, table_metadata: TableMetadata, file_
f"Cannot add file {file_path} because it has field IDs. `add_files` only supports addition of files without field_ids"
)
schema = table_metadata.schema()
_check_pyarrow_schema_compatible(schema, parquet_metadata.schema.to_arrow_schema())
downcast_ns_timestamp_to_us = Config().get_bool(DOWNCAST_NS_TIMESTAMP_TO_US_ON_WRITE) or False
_check_pyarrow_schema_compatible(
schema,
parquet_metadata.schema.to_arrow_schema(),
downcast_ns_timestamp_to_us
)

statistics = data_file_statistics_from_parquet_metadata(
parquet_metadata=parquet_metadata,
Expand Down
Loading