ci: configure codespell in pre-commit #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IndexSeek
changed the title
|
@IndexSeek thanks for the PR. could you fix the lint issue by running |
You're welcome! Good catch, sorry, forgot to lint! I added the header to the file and resolved a few codespelling violations to get pre-commit to pass. |
hussein-awala
approved these changes
Jan 3, 2025
Fokko
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
This looks great, thanks @IndexSeek for raising this PR, and thanks @kevinjqliu and @hussein-awala for reviewing this 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up with #1471 to detect spelling issues with pre-commit.
I went with adding a
.codespellrcfile to store theignore-words-list.I think it's possible to configure this in thepyproject.tomlas well. We could probably swap that out if desired.