Skip to content

Conversation

@suryaprasanna
Copy link
Contributor

@suryaprasanna suryaprasanna commented Dec 5, 2025

Describe the issue this Pull Request addresses

This PR adds test coverage for various Indexes functionality, specifically testing tag location and partition path updates for RECORD_INDEX. The existing test suite did not cover the scenario where records are updated with a new partition path after initial insertion, which is a critical feature for record-level indexing.

Summary and Changelog

Added testTagLocationDuringUpdatesAndFailures unit test that verifies:

  • Tag location returns no known locations when index is empty
  • Records are not tagged after write but before commit (uncommitted state)
  • Records are correctly tagged after commit is complete
  • Index correctly handles updates where partition path changes for existing records
  • Index distinguishes between existing records (with known locations) and new inserts when both are present in the same batch

Impact

No user-facing changes. This is a test-only addition that improves coverage for the RECORD_INDEX feature, specifically validating partition path updates which were not previously tested.

Risk Level

none - Test-only change with no impact on production code.

Documentation Update

None

Contributor's checklist

  • Read through contributor's guide
  • Enough context is provided in the sections above
  • Adequate tests were added if applicable

@suryaprasanna suryaprasanna changed the title Include unit test for record_index test(record-index): add coverage for tag location with partition path updates Dec 5, 2025
@github-actions github-actions bot added the size:S PR with lines of changes in (10, 100] label Dec 5, 2025
@suryaprasanna suryaprasanna changed the title test(record-index): add coverage for tag location with partition path updates test(record-index): add coverage for tag location call for various indexes Dec 8, 2025
@suryaprasanna suryaprasanna force-pushed the record-index-tag-location-unit-test branch from c24d9f3 to 1d495eb Compare December 8, 2025 20:11
@hudi-bot
Copy link
Collaborator

hudi-bot commented Dec 8, 2025

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S PR with lines of changes in (10, 100]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants