perf: Reduce memory usage of writing HFile log block #14078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
reviewed
Oct 13, 2025
|
hey @yihua : did you address the comment? |
nsivabalan
reviewed
Oct 20, 2025
nsivabalan
approved these changes
Oct 20, 2025
yihua
commented
Oct 20, 2025
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieDataBlock.java
Outdated
Show resolved
Hide resolved
nsivabalan
force-pushed
the
perf-improve-hfile-log-writing
branch
from
f7a717d to
ee89a96
Compare
nsivabalan
force-pushed
the
perf-improve-hfile-log-writing
branch
from
ee89a96 to
f7bc7f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
This PR addresses the inefficient memory usage during the serialization of log records to log blocks.
Summary and Changelog
HFileUtils#serializeRecordsToLogBlocknow assumes that the inputrecordsare sorted based on the record key. In this case, the sorted record mapsortedRecordsMapis no longer needed, to avoid additional memory usage when writing HFile log block.Impact
Reduces memory usage of writing HFile log block
Risk Level
low
Documentation Update
N/A
Contributor's checklist