[DNM][HUDI-9030] Run Azure CI with table version 6 #12852
Conversation
github-actions
bot
added
size:M
github-actions
bot
added
size:L
|
May I know why the CI is still failing. We are just focusing on few test classes right |
| @@ -143,7 +143,7 @@ public class HoodieWriteConfig extends HoodieConfig { | |||
|
|
|||
| public static final ConfigProperty<Integer> WRITE_TABLE_VERSION = ConfigProperty | |||
| .key("hoodie.write.table.version") | |||
| .defaultValue(HoodieTableVersion.current().versionCode()) | |||
| .defaultValue(HoodieTableVersion.SIX.versionCode()) | |||
There was a problem hiding this comment.
oh, now I see why CI is failing.
Lets keep this as 8. But only in those 15 to 20 odd tests classes, we can add option to override "hoodie.write.table.version"
So, that we can still expect a green CI for rest of test classes.
| @@ -215,7 +215,7 @@ object DataSourceReadOptions { | |||
|
|
|||
| val INCREMENTAL_FALLBACK_TO_FULL_TABLE_SCAN: ConfigProperty[String] = ConfigProperty | |||
| .key("hoodie.datasource.read.incr.fallback.fulltablescan.enable") | |||
| .defaultValue("true") | |||
| .defaultValue("false") | |||
There was a problem hiding this comment.
whats the relationship of this config to the table version?
can you help me understand.
| @@ -829,7 +829,7 @@ def testBulkInsertForDropPartitionColumn(): Unit = { | |||
| assertEquals(10, snapshotDF1.count()) | |||
| // remove metadata columns so that expected and actual DFs can be compared as is | |||
| val trimmedDf1 = dropMetaFields(snapshotDF1) | |||
| assert(df1.except(trimmedDf1).count() == 0) | |||
| //assert(df1.except(trimmedDf1).count() == 0) | |||
There was a problem hiding this comment.
why commenting out the assertions?
|
Closing the testing-only PR. |
Change Logs
Describe context and summary for this change. Highlight if any code was copied.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist