[MINOR] HoodieBackedTableMetadataWriter and HoodieTableMetadataUtil code cleanup

[codope]

Change Logs

HoodieBackedTableMetadataWriter and HoodieTableMetadataUtil code cleanup. No logic change.

• Remove unused methods and reuse some.
• Simplify metadata writer ctor.
• try-with-resource for metadata reading at some places.

Impact

Code cleanup

Risk level (write none, low medium or high below)

low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

• The config description must be updated if new configs are added or the default value of the configs are changed
• Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
  ticket number here and follow the instruction to make
  changes to the website.

Contributor's checklist

• Read through contributor's guide
• Change Logs and Impact were stated clearly
• Adequate tests were added if applicable
• CI passed

[linliu-code]

CI failures?

[linliu-code]

I cannot revert my accidental approval; so request changes to fix the CI failures.

[codope]

Thanks for the review. I will look into the CI failures. Noting here for my reference:

[ERROR] Tests run: 306, Failures: 3, Errors: 0, Skipped: 18, Time elapsed: 2,255.29 s <<< FAILURE! - in JUnit Vintage
[ERROR] [2] tableType=MERGE_ON_READ(testRLIForDeletesWithHoodieIsDeletedColumn(HoodieTableType))  Time elapsed: 3.876 s  <<< FAILURE!

[ERROR] testRLIWithEmptyPayload()(TestRecordLevelIndex)  Time elapsed: 4.265 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: deleted records should not present in RLI ==> expected: <0> but was: <2>

[ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 14.069 s <<< FAILURE! - in org.apache.hudi.client.functional.TestMetadataUtilRLIandSIRecordGeneration
[ERROR] testRecordGenerationAPIsForMOR  Time elapsed: 3.233 s  <<< FAILURE!

[hudi-bot]

CI report:

• 7bb226b Azure: FAILURE

Bot commands

@hudi-bot supports the following commands:

• @hudi-bot run azure re-run the last Azure build