-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19424. [S3A] Upgrade JUnit from 4 to 5 in hadoop-aws. #7752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
💔 -1 overall
This message was automatically generated. |
@steveloughran The JUnit 5 upgrade for the hadoop-aws module has been completed and is ready for review. I've also removed the dependency on JUnit 4. Let's take a look at the Yetus build results. If you have time, your review of this PR would be appreciated. Thank you! |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Before committing this, I would prefer if someone could run the integration tests against real S3. (If necessary, I can fake it with GCS's S3-compatible XML API, but that's not the typical usage pattern.)
@cnauroth Thank you for your help and code review! I completely agree with your point, and we indeed need other members of the community to assist in validating this part of the code. |
Description of PR
JIRA: HADOOP-19424. [S3A] Upgrade JUnit from 4 to 5 in hadoop-aws.
How was this patch tested?
mvn clean test.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?