[FLINK-40150][tests] De-parameterize rescale-history-enabled RescaleTimelineITCase tests#28749
Open
MartijnVisser wants to merge 1 commit into
Open
Conversation
…imelineITCase tests The terminated-reason tests only assert when rescale history is enabled, yet ran as @testtemplate: on the disabled parameter each paid for a MiniCluster startup before assumeThat aborted, and three rebuilt the cluster on top. Move them to a non-parameterized RescaleTimelineHistoryEnabledITCase that starts one cluster per test with the configuration it needs. Shared setup and helpers move to RescaleTimelineITCaseBase; RescaleTimelineITCase keeps the parameterized cases. Generated-by: Claude Code (Claude Opus 4.8)
Collaborator
spuru9
approved these changes
Jul 15, 2026
Contributor
|
The test failure is unrelated. But you may rerun for green CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
FLINK-40150. The six terminated-reason tests in
RescaleTimelineITCaseonly assertwhen rescale history is enabled, yet ran as
@TestTemplate: on the disabled-historyparameter each paid for a
MiniClusterstartup beforeassumeThataborted, and threerebuilt the cluster on top of that. This eliminates those wasted startups.
The jira was scoped to the 3 assume+rebuild methods; this broadens it to all 6
assume-guarded methods, since the
assume+enabled-only pattern applies to the same set.Brief change log
RescaleTimelineITCaseBase.RescaleTimelineHistoryEnabledITCase;each starts one cluster per test with the configuration it needs (no throwaway rebuild),
and the
assumeThatguards are dropped.RescaleTimelineITCasekeeps the 8 genuinely per-parameter cases (and the 2@Disabled).No production code and no behavior change; all timeouts and configs are preserved.
Verifying this change
This change is a test-only refactor covered by existing tests:
RescaleTimelineITCase(16 executed over 2 parameters, 2 disabled) andRescaleTimelineHistoryEnabledITCase(6, each run once) both pass.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Opus 4.8)