-
Notifications
You must be signed in to change notification settings - Fork 13.7k
[hotfix] Removed Extraneous Semicolon #26608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -55,7 +55,6 @@ | |||
* a complete sequence from 0 (inclusive) to 60000 (exclusive). | |||
*/ | |||
public enum FileSinkProgram { | |||
; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the Jira does not seem to exist. I suggest this is a trivial hot fix, if a committer wants to merge they can, but it is very low priority
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FLINK-28847 was the JIRA ticket that I found related to the same area. I do agree that this is fairly trivial and not at all a priority, just figured it was a quick, easy fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rionmonster could you change the title to start with [hotfix]. I will approve and suggest it be merged in the
CHI workgroup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's so strange that the JIRA isn't showing up for you. I had added a comment on it to be assigned, but either way, it's pretty trivial. I've gone ahead and updated the title accordingly.
If you'd prefer, I could also create a new PR with the non-JIRA'd commit message for consistency.
|
What is the purpose of the change
This pull request removes a unnecessary semicolon present within the
FileSinkProgram
example application for the File Sink Connector to hopefully not confuse potentially new users when exploring the repository and related connector.Brief change log
Removed a single line with a single semicolon prior to the remainder of the logic within the
FileSinkProgram
class.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation