Skip to content

[hotfix] Removed Extraneous Semicolon #26608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rionmonster
Copy link
Contributor

What is the purpose of the change

This pull request removes a unnecessary semicolon present within the FileSinkProgram example application for the File Sink Connector to hopefully not confuse potentially new users when exploring the repository and related connector.

Brief change log

Removed a single line with a single semicolon prior to the remainder of the logic within the FileSinkProgram class.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented May 28, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@@ -55,7 +55,6 @@
* a complete sequence from 0 (inclusive) to 60000 (exclusive).
*/
public enum FileSinkProgram {
;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Jira does not seem to exist. I suggest this is a trivial hot fix, if a committer wants to merge they can, but it is very low priority

Copy link
Contributor Author

@rionmonster rionmonster May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FLINK-28847 was the JIRA ticket that I found related to the same area. I do agree that this is fairly trivial and not at all a priority, just figured it was a quick, easy fix.

Copy link
Contributor

@davidradl davidradl Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rionmonster could you change the title to start with [hotfix]. I will approve and suggest it be merged in the
CHI workgroup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's so strange that the JIRA isn't showing up for you. I had added a comment on it to be assigned, but either way, it's pretty trivial. I've gone ahead and updated the title accordingly.

If you'd prefer, I could also create a new PR with the non-JIRA'd commit message for consistency.

@rionmonster rionmonster changed the title [FLINK-28847] Removed Extraneous Semicolon [hotfix] Removed Extraneous Semicolon Jun 5, 2025
@ferenc-csaky
Copy link
Contributor

FileSinkProgram is defined as an enum, so that semicolon is necessary, without it it will be syntactically incorrect, cause even though it does not have any attributes, a separator is necessary by design. This is why the CI failed. Closing this, as it is not a valid fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants