Draft pr for initial review of apicurio #24715
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Radley <[email protected]>
Signed-off-by: David Radley <[email protected]>
Signed-off-by: David Radley <[email protected]>
Signed-off-by: David Radley <[email protected]>
Signed-off-by: David Radley <[email protected]>
Signed-off-by: David Radley <[email protected]>
Signed-off-by: David Radley <[email protected]>
Signed-off-by: David Radley <[email protected]>
Signed-off-by: David Radley <[email protected]>
mnuttall
suggested changes
May 17, 2024
| Optional<String> schemaString = formatOptions.getOptional(SCHEMA); | ||
| Map<String, ?> optionalPropertiesMap = buildOptionalPropertiesMap(formatOptions); | ||
| return new ProjectableDecodingFormat<DeserializationSchema<RowData>>() { | ||
| // -------------------------------------------------------------------------------------------- |
There was a problem hiding this comment.
The comments in this method don't add very much and could probably be removed
| LogicalType convertedDataType = | ||
| AvroSchemaConverter.convertToDataType(schemaString).getLogicalType(); | ||
|
|
||
| if (convertedDataType.isNullable()) { |
There was a problem hiding this comment.
Do you make convertedDataType non-nullable because rowType is always non-nullable, and the .equals() below won't work otherwise? A comment here could be helpful.
| @Override | ||
| public Schema readSchema(InputStream in) throws IOException { | ||
| throw new IOException( | ||
| "Incompatible Kafka connector. Use a Kafka connector that passes headers"); |
There was a problem hiding this comment.
What's the connection between readSchema() and 'a Kafka connector that passes headers' ?
| public long bytesToLong(byte[] bytes) { | ||
| ByteBuffer buffer = ByteBuffer.allocate(Long.BYTES); | ||
| buffer.put(bytes); | ||
| buffer.flip(); // need flip |
| long schemaId = getSchemaId(in, additionalParameters, useGlobalId); | ||
|
|
||
| if (!useGlobalId) { | ||
| // if we are using the content ID there is not get that will dereference. |
There was a problem hiding this comment.
typo in this comment block, 'there is not get'
| // defined via general property map | ||
| properties.put("schema", SCHEMA_STRING); | ||
|
|
||
| return getModifiedOptions( |
There was a problem hiding this comment.
Could the formatting of this block be condensed?
| SerializationSchema<RowData> actualSer = | ||
| sinkMock.valueFormat.createRuntimeEncoder(null, SCHEMA.toPhysicalRowDataType()); | ||
|
|
||
| // assertThat(actualSer).isEqualTo(expectedSer); |
| sinkMock.valueFormat.createRuntimeEncoder(null, SCHEMA.toPhysicalRowDataType()); | ||
|
|
||
| // assertThat(actualSer).isEqualTo(expectedSer); | ||
| System.err.println("expectedSer:" + expectedSer + "\nactualSer:" + actualSer); |
| return nestedSchema.serialize(record); | ||
| } catch (Exception e) { | ||
| throw new RuntimeException("Failed to serialize row.", e); | ||
| throw new RuntimeException("Failed to serialize row1. record=" + record, e); |
| + inputAdditionalProperties | ||
| + ",out" | ||
| + outputAdditionalProperties); | ||
| // schemaCoder.writeSchema(getSchema(), outputStream); |
|
@mnuttall thank you very much for the review I will have a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early code for review of Apicurio Avro format prototyping