Skip to content

added the definition of done to the github templates #17801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

added the definition of done to the github templates #17801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ To make the process smooth for the project *committers* (those who review and ac
Please check out the [How to Contribute guide](https://flink.apache.org/contributing/how-to-contribute.html) to understand how contributions are made.
A detailed explanation can be found in our [Contribute Code Guide](https://flink.apache.org/contributing/contribute-code.html) which also contains a list of coding guidelines that you should follow.
For pull requests, there is a [check list](PULL_REQUEST_TEMPLATE.md) with criteria taken from the How to Contribute Guide and the Coding Guidelines.
In order to get the change merged make sure the [Definition of Done](https://flink.apache.org/contributing/contribute-code.html#definition-of-done) is fullfilled.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In order to get the change merged make sure the [Definition of Done](https://flink.apache.org/contributing/contribute-code.html#definition-of-done) is fullfilled.
In order to get the change merged make sure the [Definition of Done](https://flink.apache.org/contributing/contribute-code.html#definition-of-done) is fulfilled.

9 changes: 9 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,12 @@ This change added tests and can be verified as follows:

- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If no, was the documentation adjusted? (yes / no)

## Definition of Done

1. The implementation is following the [code contribution process](#code-contribution-process). (yes / no)
2. It is implemented according to the [code style and quality guide]({{ site.base }}/contributing/code-style-and-quality-preamble.html). (yes / no)
3. In case of user facing changes the documentation has been updated acording to the [documentation style guide]({{ site.base }}/contributing/docs-style.html). (yes / no)
4. The PR is covered by tests. (yes / no)
5. All tests passed. (yes / no)