Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5079] Enhancement update for admin-server #5080

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

xwm1992
Copy link
Contributor

@xwm1992 xwm1992 commented Aug 20, 2024

Fixes #5079

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Pil0tXia
Copy link
Member

re-triggering CI

@Pil0tXia Pil0tXia closed this Aug 20, 2024
@Pil0tXia Pil0tXia reopened this Aug 20, 2024
Copy link
Contributor

@lrhkobe lrhkobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 15.40%. Comparing base (a6018dd) to head (9ddeb87).
Report is 5 commits behind head on master.

Files Patch % Lines
...a/org/apache/eventmesh/common/remote/JobState.java 0.00% 13 Missing ⚠️
.../apache/eventmesh/common/remote/TransportType.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5080      +/-   ##
============================================
+ Coverage     15.33%   15.40%   +0.07%     
- Complexity     1521     1527       +6     
============================================
  Files           879      882       +3     
  Lines         32248    32285      +37     
  Branches       2916     2922       +6     
============================================
+ Hits           4944     4975      +31     
  Misses        26766    26766              
- Partials        538      544       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xwm1992 xwm1992 merged commit 9701f02 into apache:master Aug 21, 2024
20 of 21 checks passed
@xwm1992 xwm1992 added this to the 1.11.0 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Enhancement update for admin-server
4 participants