Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DataZoom Feature - Fixes #19732 #19835

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WZY009
Copy link

@WZY009 WZY009 commented Apr 15, 2024

Overview

This Pull Request introduces a new mobile-specific feature for the dataZoom component within ECharts. It resolves feature #19732, which requests the implementation of mobile dataZoom-Inside for horizontal and vertical using touch gestures and scrolling scale using mouse.

Changes

The following are the key changes made in this PR:

  • Enhanced InsideZoomModel.ts and InsideZoomView.ts to support touch gesture recognition for mobile devices.
  • Integrated new gesture handling logic that distinguishes between horizontal and vertical gestures to apply data zoom accordingly.

Testing

Manual testing was conducted to confirm the functionality. Test file : test/test-scroll-zoom.html

By merging this PR, ECharts will provide an enhanced interactive experience for mobile users, allowing more precise control over data visualization.

Screenshots

image

Notes

  • Additional testing on a wider range of devices is recommended to ensure universal compatibility and responsiveness.
  • Further feedback from the community can be valuable for iterative improvement of the touch interaction model.

Resolves: #19732

Copy link

echarts-bot bot commented Apr 15, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged

This message is shown because the PR description doesn't contain the document related template.

Copy link
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19835@a254f12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants