-
Notifications
You must be signed in to change notification settings - Fork 956
Feat: Add Experimental Triple HTTP/3 Support #2916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marsevilspirit
wants to merge
35
commits into
apache:develop
Choose a base branch
from
marsevilspirit:feat/triple-http3
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
659d91d
start triple http3 server successfully!
marsevilspirit 8df7d04
add http3 config for triple protocol
marsevilspirit df0e3d6
rename URL to url
marsevilspirit 65b89f2
fix v1.33.0 of google.golang.org/protobuf Fails to Compile
marsevilspirit 02da3d8
triple http3 client start successfully!
marsevilspirit ef14aac
add some comments
marsevilspirit ac3936b
update triple server run logic
marsevilspirit 91389cc
optimize http type
marsevilspirit 8ee1176
make triple http3 support keepalive option
marsevilspirit a9d9efa
add http2 keepalive config with tls
marsevilspirit 4d68ccc
rename genKeepAliveOptions
marsevilspirit 9d21484
add some todo
marsevilspirit c390d68
opitmize tlsConf params
marsevilspirit 175ad61
fix http protocol bug
marsevilspirit 1313e04
rename callProtocol
marsevilspirit 596758b
add some comments about http3 config
marsevilspirit 1aef30b
make panic when triple http3 server's TLS config is nil.
marsevilspirit 223f3d1
fix typo
marsevilspirit 7b58d74
opitmize config code
marsevilspirit 839d6e7
add experimental warning for http3 api
marsevilspirit 0bad259
add some todo
marsevilspirit 7ecec8f
support instance and yaml start with http3
marsevilspirit 49202c7
enable http3 gracefulstop
marsevilspirit 1a77738
opitmize callprotocol usage
marsevilspirit ef3bfd9
rename ProtocolClientConfig to ClientProtocolConfig
marsevilspirit 0e57b92
replace panic with return error
marsevilspirit 0b4d363
optimize logger output
marsevilspirit 9a82631
optimize parser error
marsevilspirit fee50c2
add some comments
marsevilspirit edfa8d9
add config unit tests
marsevilspirit c937f20
Use a WaitGroup to manage the concurrent shutdown of goroutines effec…
marsevilspirit f1ad8ca
fix typo and add config unit test
marsevilspirit 3917584
Merge branch 'main' into feat/triple-http3
marsevilspirit 1a30dcb
use switch to handle error
marsevilspirit 1c4c164
Merge branch 'develop' into feat/triple-http3
marsevilspirit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package config | ||
|
||
// ClientProtocolConfig represents the config of client's protocol | ||
type ClientProtocolConfig struct { | ||
// TODO: maybe we could use this field | ||
Name string `yaml:"name" json:"name,omitempty" property:"name"` | ||
|
||
TripleConfig *TripleConfig `yaml:"triple" json:"triple,omitempty" property:"triple"` | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package config | ||
|
||
// Http3Config represents the config of http3 | ||
type Http3Config struct { | ||
// Whether to enable HTTP/3 support. | ||
// The default value is false. | ||
Enable bool `yaml:"enable" json:"enable,omitempty"` | ||
// TODO: add more params about http3 | ||
|
||
// TODO: negotiation implementation | ||
// ref: https://quic-go.net/docs/http3/server/#advertising-http3-via-alt-svc | ||
// | ||
// Whether to enable HTTP/3 negotiation. | ||
// If set to false, HTTP/2 alt-svc negotiation will be skipped, | ||
// enabling HTTP/3 but disabling HTTP/2 on the consumer side. | ||
// negotiation bool | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job