-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[feat](fs)Refactor Catalog FS Access to Use Unified StorageProperties #52084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CalvinKirs
wants to merge
12
commits into
apache:master
Choose a base branch
from
CalvinKirs:master-hms-new-fs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+791
−913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-hms-new-fs # Conflicts: # fe/fe-core/src/main/java/org/apache/doris/fs/FileSystemCache.java
Description: This PR refactors the file system access logic within the Catalog framework to adopt the new StorageProperties abstraction. Many internal catalogs—such as HMS—rely on the internal file system for file access from the Frontend (FE). This change ensures that all file system operations initiated within the Catalog layer now use the unified StorageProperties mechanism, which provides consistent configuration handling and supports pluggable backends like HDFS, S3, OSS, COS, etc. Changes: Integrated StorageProperties into Catalog-related file system logic. Replaced legacy FS property resolution with StorageProperties throughout Catalog modules. Ensured backward compatibility with existing Catalogs using internal FS (e.g., HMS). Refactored test cases to assert FS normalization behavior line-by-line instead of using a static map.
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
…er-hms-new-fs # Conflicts: # fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogProperty.java
run buildall |
TPC-H: Total hot run time: 33941 ms
|
TPC-DS: Total hot run time: 186295 ms
|
ClickBench: Total hot run time: 29.53 s
|
run buildall |
TPC-H: Total hot run time: 33931 ms
|
TPC-DS: Total hot run time: 185691 ms
|
ClickBench: Total hot run time: 29.22 s
|
run buildall |
TPC-H: Total hot run time: 34153 ms
|
TPC-DS: Total hot run time: 186120 ms
|
ClickBench: Total hot run time: 28.91 s
|
run buildall |
TPC-H: Total hot run time: 33776 ms
|
TPC-DS: Total hot run time: 184935 ms
|
ClickBench: Total hot run time: 29.05 s
|
run buildall |
TPC-H: Total hot run time: 34732 ms
|
TPC-DS: Total hot run time: 186159 ms
|
ClickBench: Total hot run time: 29.61 s
|
FE UT Coverage ReportIncrement line coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Refactor Catalog FS Access to Use Unified StorageProperties
Description:
This PR refactors the file system access logic within the Catalog framework to adopt the new StorageProperties abstraction. Many internal catalogs—such as HMS—rely on the internal file system for file access from the Frontend (FE).
This change ensures that all file system operations initiated within the Catalog layer now use the unified StorageProperties mechanism, which provides consistent configuration handling and supports pluggable backends like HDFS, S3, OSS, COS, etc.
Changes:
Integrated StorageProperties into Catalog-related file system logic.
Replaced legacy FS property resolution with StorageProperties throughout Catalog modules.
Ensured backward compatibility with existing Catalogs using internal FS (e.g., HMS).
Refactored test cases to assert FS normalization behavior line-by-line instead of using a static map.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)