[fix](nereids)LogicalPlanDeepCopier will lost some info when coping logical relation #34894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 39809 ms |
TPC-DS: Total hot run time: 186053 ms |
ClickBench: Total hot run time: 30.59 s |
morrySnow
reviewed
May 15, 2024
| @@ -101,6 +101,11 @@ public Plan withGroupExprLogicalPropChildren(Optional<GroupExpression> groupExpr | |||
| return new UnboundTVFRelation(relationId, functionName, properties, groupExpression, logicalProperties); | |||
| } | |||
|
|
|||
| @Override | |||
| public UnboundTVFRelation withRelationId(RelationId relationId) { | |||
| throw new RuntimeException("should not call UnboundTVFRelation's withRelationId method"); | |||
There was a problem hiding this comment.
visitLogicalDeferMaterializeOlapScan should also add to relation id map
| Optional.empty(), Optional.empty(), | ||
| selectedPartitionIds, partitionPruned, selectedTabletIds, | ||
| selectedIndexId, indexSelected, preAggStatus, manuallySpecifiedPartitions, | ||
| hints, cacheSlotWithSlotName, tableSample, directMvScan, projectPulledUp); |
There was a problem hiding this comment.
cacheSlotWithSlotName should be removed
| @@ -89,6 +89,11 @@ public Plan withGroupExprLogicalPropChildren(Optional<GroupExpression> groupExpr | |||
| return new LogicalOneRowRelation(relationId, projects, groupExpression, logicalProperties); | |||
| } | |||
|
|
|||
| @Override | |||
| public LogicalOneRowRelation withRelationId(RelationId relationId) { | |||
| return new LogicalOneRowRelation(relationId, projects, Optional.empty(), Optional.empty()); | |||
There was a problem hiding this comment.
should not impl, throw exception
| @@ -81,6 +81,11 @@ public Plan withGroupExprLogicalPropChildren(Optional<GroupExpression> groupExpr | |||
| return new LogicalEmptyRelation(relationId, projects, groupExpression, logicalProperties); | |||
| } | |||
|
|
|||
| @Override | |||
| public LogicalEmptyRelation withRelationId(RelationId relationId) { | |||
| return new LogicalEmptyRelation(relationId, projects, Optional.empty(), Optional.empty()); | |||
starocean999
force-pushed
the
nereids_1025
branch
from
660d50d
to
ca4db85
Compare
|
run buildall |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 40696 ms |
TPC-DS: Total hot run time: 187627 ms |
ClickBench: Total hot run time: 30.45 s |
|
run buildall |
morrySnow
approved these changes
May 15, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 41971 ms |
TPC-DS: Total hot run time: 186308 ms |
ClickBench: Total hot run time: 30.91 s |
englefly
approved these changes
May 16, 2024
TPC-DS: Total hot run time: 187104 ms |
ClickBench: Total hot run time: 30.56 s |
|
run performance |
dataroaring
pushed a commit
that referenced
this pull request
May 16, 2024
…ogical relation (#34894)
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
May 20, 2024
intro by PR apache#34894 This PR attempts to address the issue of losing conjuncts when performing a deep copy of the outer structure. However, the timing of copying the conjuncts is incorrect, resulting in the inability to map slots within the conjuncts to the output of the outer structure.
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
May 20, 2024
intro by PR apache#34894 This PR attempts to address the issue of losing conjuncts when performing a deep copy of the outer structure. However, the timing of copying the conjuncts is incorrect, resulting in the inability to map slots within the conjuncts to the output of the outer structure.
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
May 20, 2024
intro by PR apache#34894 This PR attempts to address the issue of losing conjuncts when performing a deep copy of the outer structure. However, the timing of copying the conjuncts is incorrect, resulting in the inability to map slots within the conjuncts to the output of the outer structure.
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
May 20, 2024
intro by PR apache#34894 This PR attempts to address the issue of losing conjuncts when performing a deep copy of the outer structure. However, the timing of copying the conjuncts is incorrect, resulting in the inability to map slots within the conjuncts to the output of the outer structure.
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
May 20, 2024
intro by PR apache#34894 This PR attempts to address the issue of losing conjuncts when performing a deep copy of the outer structure. However, the timing of copying the conjuncts is incorrect, resulting in the inability to map slots within the conjuncts to the output of the outer structure.
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
May 20, 2024
intro by PR apache#34894 This PR attempts to address the issue of losing conjuncts when performing a deep copy of the outer structure. However, the timing of copying the conjuncts is incorrect, resulting in the inability to map slots within the conjuncts to the output of the outer structure.
M1saka2003
pushed a commit
to M1saka2003/doris
that referenced
this pull request
May 24, 2024
M1saka2003
pushed a commit
to M1saka2003/doris
that referenced
this pull request
May 24, 2024
…apache#35076) intro by PR apache#34894 PR apache#34894 attempts to address the issue of losing conjuncts when performing a deep copy of the outer structure. However, the timing of copying the conjuncts is incorrect, resulting in the inability to map slots within the conjuncts to the output of the scan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...