Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhance](FileWriter) Prevent multiple invocation to FileWriter's close function #34890

Merged
merged 1 commit into from
May 15, 2024

Conversation

ByteYue
Copy link
Contributor

@ByteYue ByteYue commented May 15, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@ByteYue
Copy link
Contributor Author

ByteYue commented May 15, 2024

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.66% (8983/25194)
Line Coverage: 27.32% (74268/271839)
Region Coverage: 26.56% (38387/144547)
Branch Coverage: 23.38% (19580/83764)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3edc29504f82d575054e19ec7847a7886a8188be_3edc29504f82d575054e19ec7847a7886a8188be/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 41999 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3edc29504f82d575054e19ec7847a7886a8188be, data reload: false

------ Round 1 ----------------------------------
q1	17620	4311	4248	4248
q2	2011	185	201	185
q3	10454	1232	1260	1232
q4	10186	833	772	772
q5	7476	2745	2706	2706
q6	228	141	138	138
q7	1001	621	595	595
q8	9233	2163	2117	2117
q9	9137	6752	6643	6643
q10	9030	3904	3878	3878
q11	460	250	236	236
q12	450	220	222	220
q13	17785	3232	3192	3192
q14	266	217	226	217
q15	529	464	484	464
q16	526	406	406	406
q17	959	687	690	687
q18	8478	7932	7816	7816
q19	4308	1533	1528	1528
q20	652	325	319	319
q21	5304	4125	4193	4125
q22	359	278	275	275
Total cold run time: 116452 ms
Total hot run time: 41999 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4563	4412	4352	4352
q2	377	289	277	277
q3	3151	2887	2861	2861
q4	2006	1657	1613	1613
q5	5410	5523	5529	5523
q6	217	135	131	131
q7	2338	1994	1964	1964
q8	3287	3441	3399	3399
q9	8706	8767	8785	8767
q10	4110	3767	3904	3767
q11	641	529	500	500
q12	811	627	658	627
q13	16151	3119	3170	3119
q14	310	284	292	284
q15	540	489	481	481
q16	524	444	437	437
q17	1863	1501	1469	1469
q18	7774	7479	7473	7473
q19	1660	1551	1562	1551
q20	1980	1749	1792	1749
q21	11163	4878	4799	4799
q22	534	459	474	459
Total cold run time: 78116 ms
Total hot run time: 55602 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187053 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3edc29504f82d575054e19ec7847a7886a8188be, data reload: false

query1	917	394	380	380
query2	6431	2567	2190	2190
query3	6641	220	217	217
query4	23012	21241	21362	21241
query5	4129	439	429	429
query6	257	200	171	171
query7	4573	291	285	285
query8	248	211	190	190
query9	8489	2398	2389	2389
query10	431	255	252	252
query11	14928	14236	14273	14236
query12	142	92	89	89
query13	1643	375	402	375
query14	11272	7011	7678	7011
query15	210	169	172	169
query16	7487	278	255	255
query17	1306	540	537	537
query18	1945	283	267	267
query19	201	150	146	146
query20	91	85	84	84
query21	195	128	140	128
query22	5035	4881	4833	4833
query23	33909	33396	33528	33396
query24	4974	2925	2904	2904
query25	466	371	374	371
query26	697	158	152	152
query27	1842	321	353	321
query28	3607	2091	2061	2061
query29	858	611	612	611
query30	258	178	174	174
query31	907	757	732	732
query32	62	55	57	55
query33	449	246	243	243
query34	869	488	474	474
query35	766	679	668	668
query36	1075	920	898	898
query37	109	70	69	69
query38	2867	2776	2711	2711
query39	1578	1549	1540	1540
query40	204	126	124	124
query41	49	42	43	42
query42	107	96	99	96
query43	591	538	515	515
query44	1076	732	745	732
query45	264	255	260	255
query46	1056	724	744	724
query47	1947	1879	1870	1870
query48	377	299	293	293
query49	769	397	400	397
query50	772	388	399	388
query51	6869	6725	6841	6725
query52	105	90	93	90
query53	355	286	288	286
query54	547	434	458	434
query55	77	77	82	77
query56	252	237	233	233
query57	1268	1136	1144	1136
query58	223	214	218	214
query59	3398	3419	3260	3260
query60	264	269	248	248
query61	120	106	106	106
query62	601	477	461	461
query63	311	288	285	285
query64	7834	7461	7496	7461
query65	3143	3101	3127	3101
query66	738	353	354	353
query67	15657	15148	15247	15148
query68	4847	540	543	540
query69	541	315	308	308
query70	1213	1115	1170	1115
query71	475	276	276	276
query72	8371	2675	2479	2479
query73	716	331	323	323
query74	6612	6116	6116	6116
query75	3716	2642	2692	2642
query76	3273	1050	1020	1020
query77	587	276	282	276
query78	10802	10276	10012	10012
query79	6491	524	530	524
query80	1850	457	461	457
query81	547	248	253	248
query82	1693	104	100	100
query83	301	174	312	174
query84	266	122	84	84
query85	1059	286	257	257
query86	454	304	306	304
query87	3283	3133	3101	3101
query88	4666	2355	2372	2355
query89	507	378	393	378
query90	2170	188	187	187
query91	124	98	99	98
query92	56	49	50	49
query93	5880	507	494	494
query94	1073	179	182	179
query95	388	297	297	297
query96	596	265	264	264
query97	3177	2985	3028	2985
query98	244	215	216	215
query99	1211	911	888	888
Total cold run time: 281039 ms
Total hot run time: 187053 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.58 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3edc29504f82d575054e19ec7847a7886a8188be, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.67	0.09	0.08
query5	0.53	0.48	0.52
query6	1.11	0.71	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.48	0.50
query10	0.54	0.55	0.54
query11	0.15	0.11	0.11
query12	0.16	0.12	0.12
query13	0.60	0.60	0.60
query14	0.79	0.76	0.77
query15	0.84	0.80	0.80
query16	0.37	0.36	0.35
query17	0.99	1.03	0.98
query18	0.24	0.23	0.24
query19	1.78	1.77	1.73
query20	0.02	0.01	0.01
query21	15.74	0.64	0.64
query22	4.67	6.66	2.11
query23	18.29	1.30	1.25
query24	1.83	0.25	0.21
query25	0.15	0.09	0.09
query26	0.26	0.17	0.18
query27	0.09	0.08	0.07
query28	13.31	1.00	0.99
query29	13.77	3.29	3.24
query30	0.24	0.05	0.05
query31	2.88	0.39	0.38
query32	3.28	0.47	0.47
query33	2.75	2.82	2.85
query34	17.26	4.38	4.44
query35	4.50	4.50	4.58
query36	0.65	0.48	0.46
query37	0.17	0.16	0.16
query38	0.15	0.15	0.14
query39	0.04	0.04	0.03
query40	0.16	0.14	0.14
query41	0.09	0.05	0.05
query42	0.06	0.04	0.05
query43	0.03	0.04	0.04
Total cold run time: 111.12 s
Total hot run time: 30.58 s

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 15, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 1c35309 into apache:master May 15, 2024
26 of 29 checks passed
M1saka2003 pushed a commit to M1saka2003/doris that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants