[DSIP-39][parameter] Improvement startup parameters/global parameters/project parameters data type #15967

sdhzwc · 2024-05-10T01:30:59Z

close #15936

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

…ters data type

# Conflicts: # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ExecutorController.java # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java

SbloodyS

Please add the docs. @sdhzwc

sdhzwc · 2024-05-10T01:44:09Z

Please add the docs。 @sdhzwc

Yesterday I got feedback that the front-end compilation failed, so I'll improve the documentation when I've solved this problem.

SbloodyS · 2024-05-10T01:46:18Z

Yesterday I got feedback that the front-end compilation failed, so I'll improve the documentation when I've solved this problem.

pnpm run build:prod command failed. You can test it locally.

codecov-commenter · 2024-05-10T02:07:36Z

Codecov Report

Attention: Patch coverage is 33.33333% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 40.60%. Comparing base (dbd790d) to head (272fa28).
Report is 1 commits behind head on dev.

❗ Current head 272fa28 differs from pull request most recent head bdbb330

Please upload reports for the commit bdbb330 to get more accurate results.

Files	Patch %	Lines
...scheduler/plugin/task/api/utils/PropertyUtils.java	0.00%	14 Missing ⚠️
...eduler/service/expand/CuringParamsServiceImpl.java	66.66%	2 Missing and 1 partial ⚠️
...cheduler/api/service/impl/ExecutorServiceImpl.java	0.00%	1 Missing and 1 partial ⚠️
...inscheduler/api/controller/ExecutorController.java	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                dev   #15967      +/-   ##
============================================
- Coverage     40.63%   40.60%   -0.03%     
+ Complexity     5222     5221       -1     
============================================
  Files          1380     1381       +1     
  Lines         46066    46080      +14     
  Branches       4916     4917       +1     
============================================
- Hits          18718    18712       -6     
- Misses        25423    25443      +20     
  Partials       1925     1925

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruanwenjun · 2024-05-10T02:20:45Z

I tried to compile the frontend locally but failed.

# Conflicts: # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java

…d Show Commands table list (apache#15978) * update * test * add monitor enhance ui * update * update * update doc * fix spotless * update * update * Update dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.java Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.xml Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/CommandMapper.java Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.xml Co-authored-by: Wenjun Ruan <[email protected]> * update * fix spotless * update --------- Co-authored-by: Wenjun Ruan <[email protected]>

sdhzwc · 2024-05-16T01:05:36Z

@ruanwenjun That should do it.

ruanwenjun

Backend LGTM

SbloodyS

+1

SbloodyS · 2024-05-21T05:38:02Z

Please fix UT. @sdhzwc

sonarcloud · 2024-05-21T07:33:13Z

Quality Gate failed

Failed conditions
36.8% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

…ASF release (#16042) * add version of 3.2.2 * Fix rpc channel leak due to concurrent operation (#16021) * Fix rpc channel leak due to concurrent operation * Throw channel create failed exception --------- Co-authored-by: Rick Cheng <[email protected]> * Fix WorkerTaskExecutorThreadPool#isOverload is incorrect (#16027) * cp: Reduce the size of tarball to continue ASF release (#15004) (#15540) * Reduce the size of tarball to continue ASF release for more detail you can see https://lists.apache.org/thread/rmp7fghlj0n7h9y2v3p8gkw9f9qbo6qt # Conflicts: # tools/dependencies/known-dependencies.txt * Increase block-until-connected in ZookeeperRegistryTestCase (#16041) * [Fix][CI] fix the ci error of Values.datasource.profile (#16031) Co-authored-by: Eric Gao <[email protected]> * Correction of Typos in the Chinese Document Appendix for Task Parameters (#16033) Co-authored-by: Rick Cheng <[email protected]> * [DSIP-39][parameter] Improvement startup parameters/global parameters/project parameters data type (#15967) * [Improvement][parameter] New data types and type filtering * [Improvement][parameter] Improvement startup parameters/global parameters data type * fix api interfaces compatible * add project parameter data type default value * [Improvement][parameter] New data types and type filtering * [Improvement][parameter] Improvement startup parameters/global parameters data type * fix api interfaces compatible * add project parameter data type default value * improvement project code * remove useless imports * remove method onClearSearchTaskType * add parameter doc * optimisation logic * code conflict resolution * code conflict resolution * [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list (#15978) * update * test * add monitor enhance ui * update * update * update doc * fix spotless * update * update * Update dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.java Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.xml Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/CommandMapper.java Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.xml Co-authored-by: Wenjun Ruan <[email protected]> * update * fix spotless * update --------- Co-authored-by: Wenjun Ruan <[email protected]> * [Improvement][Monitor] Add UT for montor (#15998) * formatting Code * add pom * Fix NettyRemotingClient might throw IllegalMonitorStateException (#16038) * Removed unused StateEventHandleFailure (#16052) * Remove OmitStackTraceInFastThrow in start.sh (#16054) * Update Chart.yaml Rollback APPversion * modify log msg (#16062) Co-authored-by: xiangzihao <[email protected]> * [DS-16046][fix] Set PreparedStatement parameter type (#16050) Fix the PreparedStatement parameter is TIME, set it to java.sql.Time Co-authored-by: Aaron Wang <[email protected]> Co-authored-by: Rick Cheng <[email protected]> * Update pom.xml * [DSIP-42] Add dolphinscheduler-aws-authentication module (#16043) --------- Co-authored-by: wangxj <wangxj31> Co-authored-by: Wenjun Ruan <[email protected]> Co-authored-by: Rick Cheng <[email protected]> Co-authored-by: Eric Gao <[email protected]> Co-authored-by: TianXinCoord <[email protected]> Co-authored-by: 小可耐 <[email protected]> Co-authored-by: sleo <[email protected]> Co-authored-by: xiangzihao <[email protected]> Co-authored-by: yinxiaolog <[email protected]> Co-authored-by: Aaron Wang <[email protected]>

sdhzwc and others added 13 commits April 30, 2024 14:14

[Improvement][parameter] New data types and type filtering

c017ac8

[Improvement][parameter] Improvement startup parameters/global parame…

8d547d2

…ters data type

fix api interfaces compatible

f654e04

add project parameter data type default value

3271d7e

[Improvement][parameter] New data types and type filtering

b72d400

[Improvement][parameter] Improvement startup parameters/global parame…

eb157ce

…ters data type

fix api interfaces compatible

20cecde

add project parameter data type default value

d01d3de

improvement project code

bcd4fad

Merge remote-tracking branch 'origin/dev' into dev

4236478

# Conflicts: # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ExecutorController.java # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java

Merge branch 'dev' into dev

3b4fc60

remove useless imports

33a0c14

Merge remote-tracking branch 'origin/dev' into dev

95b5aa3

sdhzwc requested review from songjianet, Amy0104, caishunfeng, EricGao888 and SbloodyS as code owners May 10, 2024 01:31

github-actions bot added UI ui and front end related backend labels May 10, 2024

SbloodyS assigned sdhzwc May 10, 2024

SbloodyS added feature new feature 3.3.0 labels May 10, 2024

SbloodyS added this to the 3.3.0 milestone May 10, 2024

SbloodyS reviewed May 10, 2024

View reviewed changes

SbloodyS added the miss:docs missing documents in PR label May 10, 2024

ruanwenjun added the DSIP label May 15, 2024

songjianet previously approved these changes May 15, 2024

View reviewed changes

ruanwenjun and others added 2 commits May 15, 2024 13:50

Merge branch 'dev' into dev

5b49f3f

code conflict resolution

d7481f4

sdhzwc dismissed stale reviews from ruanwenjun and songjianet via d7481f4 May 15, 2024 08:04

sdhzwc added 2 commits May 15, 2024 16:18

code conflict resolution

68eaa5a

Merge remote-tracking branch 'origin/DSIP-39' into DSIP-39

5351a2a

# Conflicts: # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java

sdhzwc closed this May 15, 2024

sdhzwc mentioned this pull request May 15, 2024

[DSIP-39][parameter] Improvement startup parameters/global parameters/project parameters data type #16002

Closed

sdhzwc reopened this May 15, 2024

sdhzwc closed this May 15, 2024

ruanwenjun reopened this May 15, 2024

qingwli and others added 3 commits May 16, 2024 09:00

[Improvement][Monitor] Add UT for montor (apache#15998)

969fdd0

Merge remote-tracking branch 'origin/DSIP-39' into DSIP-39

622cf49

sdhzwc and others added 2 commits May 16, 2024 09:11

formatting Code

6cadfa9

Merge branch 'dev' into dev

90c5b47

ruanwenjun approved these changes May 16, 2024

View reviewed changes

ruanwenjun requested a review from songjianet May 17, 2024 01:34

ruanwenjun removed the miss:docs missing documents in PR label May 18, 2024

Merge branch 'dev' into dev

f0d014f

SbloodyS approved these changes May 21, 2024

View reviewed changes

Merge branch 'dev' into dev

cbbe09d

Merge branch 'dev' into dev

bdbb330

SbloodyS merged commit 0fc2fe9 into apache:dev May 21, 2024
65 of 66 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DSIP-39][parameter] Improvement startup parameters/global parameters/project parameters data type #15967

[DSIP-39][parameter] Improvement startup parameters/global parameters/project parameters data type #15967

sdhzwc commented May 10, 2024 •

edited by SbloodyS

SbloodyS left a comment

sdhzwc commented May 10, 2024

SbloodyS commented May 10, 2024

codecov-commenter commented May 10, 2024 •

edited

ruanwenjun commented May 10, 2024

sdhzwc commented May 16, 2024

ruanwenjun left a comment

SbloodyS left a comment

SbloodyS commented May 21, 2024

sonarcloud bot commented May 21, 2024

[DSIP-39][parameter] Improvement startup parameters/global parameters/project parameters data type #15967

[DSIP-39][parameter] Improvement startup parameters/global parameters/project parameters data type #15967

Conversation

sdhzwc commented May 10, 2024 • edited by SbloodyS

Purpose of the pull request

Brief change log

Verify this pull request

SbloodyS left a comment

Choose a reason for hiding this comment

sdhzwc commented May 10, 2024

SbloodyS commented May 10, 2024

codecov-commenter commented May 10, 2024 • edited

Codecov Report

ruanwenjun commented May 10, 2024

sdhzwc commented May 16, 2024

ruanwenjun left a comment

Choose a reason for hiding this comment

SbloodyS left a comment

Choose a reason for hiding this comment

SbloodyS commented May 21, 2024

sonarcloud bot commented May 21, 2024

Quality Gate failed

sdhzwc commented May 10, 2024 •

edited by SbloodyS

codecov-commenter commented May 10, 2024 •

edited