[DSIP] Support ssl at RPC #15802
[DSIP] Support ssl at RPC #15802
Conversation
|
|
||
|
|
||
| /** | ||
| * netty config enable | ||
| */ | ||
| public static final String NETTY_SSL_ENABLE = "netty.ssl.enable"; | ||
|
|
||
| public static final String NETTY_SSL_KEY_PATH = "netty.ssl.key.path"; | ||
|
|
||
| public static final String NETTY_SSL_CERT_PATH = "netty.ssl.cert.path"; |
There was a problem hiding this comment.
Pleas move this kind of config into application.yaml, we shouldn't add new config into common.properties.
rpc:
ssl:
enable: true
cert-file:
key-file:
There was a problem hiding this comment.
i add config into common.properties,Because if the master service uses SSL authentication, the worker must also be configured。 so i think only config into common better than config both into master and worker
There was a problem hiding this comment.
Overall LGTM, Even if these configs are in common.properties, the common.properties of the master and worker may have different configs. I think it is necessary to deal with the inconsistency in encryption.
So I agree with @ruanwenjun that we could move these configs to application.yaml
...extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/NettyRemotingClient.java
Outdated
Show resolved
Hide resolved
|
Since this will import new feature, please create a DSIP issue, you can follow #14102 |
of course ,I will add it recently |
…n/java/org/apache/dolphinscheduler/extract/base/NettyRemotingClient.java Co-authored-by: Wenjun Ruan <[email protected]>
|
I want to wait until my code structure is ok and everyone’s review has passed before I add UT. @ruanwenjun @rickchengx |
|
The documentation on how to use SSL also needs to be updated. At the same time, the Helm charts need to be updated to support this capability. @fuchanghai |
get |
# Conflicts: # dolphinscheduler-alert/dolphinscheduler-alert-server/src/main/java/org/apache/dolphinscheduler/alert/rpc/AlertRpcServer.java # dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/LoggerServiceTest.java # dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/client/NettyRemotingClient.java # dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/server/NettyRemotingServer.java # dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/server/NettyRemotingServerFactory.java # dolphinscheduler-extract/dolphinscheduler-extract-base/src/test/java/org/apache/dolphinscheduler/extract/base/client/SingletonJdkDynamicRpcClientProxyFactoryTest.java # dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/rpc/MasterRpcServer.java # dolphinscheduler-microbench/src/main/java/org/apache/dolphinscheduler/microbench/rpc/RpcBenchMarkTest.java # dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/rpc/WorkerRpcServer.java
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15802 +/- ##
============================================
- Coverage 39.93% 39.86% -0.08%
+ Complexity 5081 5061 -20
============================================
Files 1369 1369
Lines 45635 45662 +27
Branches 4869 4872 +3
============================================
- Hits 18224 18201 -23
- Misses 25513 25558 +45
- Partials 1898 1903 +5 ☔ View full report in Codecov by Sentry. |
|
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md