Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on physical-optimizer on functions-aggregates #14134

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 15, 2025

Draft it is based on #14083 from @mnpw

Which issue does this PR close?

This is a follow up to

Rationale for this change

We are trying to make sure datafusion-physical-optimizers are not dependent on the actual function implementations so ensuring the crate doesn't have dependency will let the compiler ensure this

What changes are included in this PR?

Remove the dependency

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions optimizer Optimizer rules core Core DataFusion crate labels Jan 15, 2025
@alamb alamb force-pushed the alamb/remove_dependency branch from c1ed7a0 to d2bab2b Compare January 16, 2025 15:20
@github-actions github-actions bot removed the core Core DataFusion crate label Jan 16, 2025
@alamb alamb marked this pull request as ready for review January 16, 2025 15:29
Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alamb
Copy link
Contributor Author

alamb commented Jan 17, 2025

Thank you for the review @jonahgao 🙏

@alamb alamb merged commit 5d9be90 into apache:main Jan 17, 2025
27 checks passed
@@ -252,6 +252,10 @@ impl AggregateUDFImpl for Count {
Ok(DataType::Int64)
}

fn is_nullable(&self) -> bool {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW this makes the count function stub match the actual count function which is also not nullable

This was required to get the existing tests to pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants