[CXF-9019] Jaxws spi unit test coverage enhancement. #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will update for importing ordering. |
reta
pushed a commit
that referenced
this pull request
May 24, 2024
* [cxf-rt-frontend-jaxws] Improve JAXWS SPI unit test coverage * Add header to WrapperClassCreatorProxyServiceTest * Fix imports (cherry picked from commit 6ad50d5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provided unit test enhancement helps provide wider coverage of ProviderImpl, and introduces coverage to the WrapperClassLoader.
In ProviderImpl we add test cases for most methods - we do not dive too deep into underlying objects/services - those have their own unit tests to assert correctness.
In the case of WrapperClassLoader we mock the class loader behavoir in order to exercise the generate and createWrapperClass functionality.