Remove h from ESCAPED_CHARS in JsonMapObjectReaderWriter #1872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JsonMapObjectReaderWriter class maintains a list of ESCAPED_CHARS which includes special characters that need to be escaped like the newline (
\n
) and tab (\t
) characters. This list also includes\h
, but I can't find any links to official documentation about this character needing to be escaped.According to this SO post which details escaped characters in JSON, it also does not include
\h
in this list.I'm opening a PR to discuss removing this from the list.
Issue in OpenSearch where this issue is discussed: opensearch-project/security#2531 (comment)
Simple test case which demonstrates the difference:
Output:
jwt2 has an invalid payload.