TEXT-126: Adding Sorensen-Dice similarity algorithm #621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #103
The work in #103 seemed to be going in the right direction but needed some review before being merged. I started syncing the code and rebasing it, but noticed that the code had been done on
master
branch in a fork. However, thatmaster
branch was later overwritten by other commits for other pull requests.This means I am not able to update the pull request (or at least I cannot think of a way of doing so), thus this new pull request with the same change (one commit with the same author, OP).
There were a few merge commits, which I rebased squashing everything into a single commit, keeping just the two files that were being displayed in the GitHub UI diff, and that contain the class and test for the Sorensen-Dice algo.
I will try to move it forward, even if the review comments are not displayed here. In case I do not managed to finish it, anyone is welcome to take it over. Just to make sure to read the feedback in the linked pull request, and address or comment CC'in others.