FTPES with TLS Session Reuse for FileZilla Server (need also BouncyCastle and a subclass). #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and a subclass). Connecting to ftp.example.com on the command port and then to the corresponding IP x.x.x.x on the data port prevents the server from accepting the same TLS session. Therefore, the Filezilla server needs to set peerHost before socket.connect to allow TLS session resumption.
garydgregory
requested changes
Jan 15, 2025
There was a problem hiding this comment.
Hello @deguich
There are 2 issues with this PR:
- No tests:
- This is just an invitation for future changes to inadvertently undo or break the behavior in this PR. A test should fail if the changes to
mainare not applied. - Look at the existing tests for inspiration here and in other Commons components
- If this is a FileZilla specific change, you might need to run a test that runs FileZilla in Docker using a Docker Maven plugin like https://github.com/fabric8io/docker-maven-plugin
- This is just an invitation for future changes to inadvertently undo or break the behavior in this PR. A test should fail if the changes to
- You did not follow the instructions in the PR template: You did not run
mvnby itself or you would have caught this build failure:
[INFO] --- checkstyle:3.6.0:check (default-cli) @ commons-net ---
[INFO] There are 3 errors reported by Checkstyle 10.21.1 with src/conf/checkstyle.xml ruleset.
[ERROR] src\main\java\org\apache\commons\net\ftp\FTPSClient.java:[315] (regexp) RegexpSingleline: Line has trailing spaces.
[ERROR] src\main\java\org\apache\commons\net\ftp\FTPSClient.java:[834] (regexp) RegexpSingleline: Line has trailing spaces.
[ERROR] src\main\java\org\apache\commons\net\ftp\FTPSClient.java:[876] (regexp) RegexpSingleline: Line has trailing spaces.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
| @@ -313,7 +312,7 @@ protected Socket _openDataConnection_(final String command, final String arg) th | |||
| */ | |||
| protected void _prepareDataSocket_(final Socket socket) throws IOException { | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
No extra whitespace please.
…(with SNI) in passive mode.
|
You can enable SNI (Server Name Indication) test by using external filezilla server (SSL session reuse always works when using docker on localhost and bouncycastle lib) : src\test\resources\org\apache\commons\net\filezillaserver\filezillaserver.properties |
garydgregory
requested changes
Feb 16, 2025
| <version>1.7.32</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <!--<dependency> |
There was a problem hiding this comment.
I don't think we need this comment block.
| </excludes> | ||
| <environmentVariables> | ||
| <TRACE_CALLS>${commons.net.trace_calls}</TRACE_CALLS> | ||
| <ADD_LISTENER>${commons.net.add_listener}</ADD_LISTENER> | ||
| </environmentVariables> | ||
| </configuration> | ||
| </plugin> | ||
| <!-- Plugin Failsafe for integration-tests --> |
There was a problem hiding this comment.
You don't need to state what a plugin is.
|
Hello @deguich |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connecting to ftp.example.com on the command port and then to the corresponding IP x.x.x.x on the data port prevents the server from accepting the same TLS session. Therefore, the Filezilla server needs to set peerHost before socket.connect to allow TLS session resumption.
With this new version, FTPeS to the server with TLS session resumption works with this subclass :