NET-727 enable accessing options map for TFTP request packet #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkbkupczyk
reviewed
Jan 13, 2025
| @@ -56,6 +59,9 @@ public abstract class TFTPRequestPacket extends TFTPPacket { | |||
| /** The file name of the request. */ | |||
| private final String fileName; | |||
|
|
|||
| /** The option values */ | |||
| private Map<String, String> options = new HashMap<>(); | |||
There was a problem hiding this comment.
I think options can be final.
There was a problem hiding this comment.
thank you for pointing that out , I've changed it to be final
Comment on lines
62
to
63
| /** The option values */ | ||
| private Map<String, String> options = new HashMap<>(); |
There was a problem hiding this comment.
According to rfc2347. A new error code with value 8 is defined to indicate that a transfer should be terminated due to option negotiation. I think you can safely add new err code to TFTPErrorPacket ;)
There was a problem hiding this comment.
I've updated the TFTPErrorPacket to have the error code.
…be used to denote invalid options)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to existing https://issues.apache.org/jira/browse/NET-727
This changes only includes the mapping of
optionsmap in TFTPRequestPacket which would be towards implementing RFC2347. For my use case only requirement was to get theblksize(RFC2348) from the request packet and would like to move on to try my luck with implementing the RFC2347.