-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSV-216: Add mutator withValue() to CSVRecord #25
Open
stain
wants to merge
10
commits into
master
Choose a base branch
from
CSV-216
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b23f963
[CSV-216] Allow for mutable CSV records.
garydgregory 41101f1
Javadoc.
garydgregory d482fd2
Merge branch 'master' into CSV-216
stain c290f13
CSV-216: Javadoc of @param mutableREcords
stain bb949ad
CSV-216 add mutator functions
stain 6eebeb0
CSV-216: Avoid references to CSVMutableRecord
stain c66ea98
CSV-216 test mutators
stain 637ad2d
CSV-216: Avoid sharing CSVRecord.comment field
stain f66a839
CSV-216: Avoid Arrays.copyOf()
stain b81b547
Warning about .clone()
stain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
src/main/java/org/apache/commons/csv/CSVMutableRecord.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.commons.csv; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| /** | ||
| * A mutable version of CSVRecord | ||
| * <p> | ||
| * As mutation is generally done within the parent {@link CSVRecord}, this | ||
| * package-private class just includes more efficient versions of | ||
| * mutator functions, bypassing the need to make copies | ||
| * (except in {@link #immutable()}). | ||
| * <p> | ||
| * To enable generating CSVMutableRecord by default, set | ||
| * {@link CSVFormat#withMutableRecords(boolean)} to <code>true</code>. | ||
| * | ||
| */ | ||
| final class CSVMutableRecord extends CSVRecord { | ||
|
|
||
| private static final long serialVersionUID = 1L; | ||
|
|
||
| CSVMutableRecord(String[] values, Map<String, Integer> mapping, String comment, long recordNumber, | ||
| long characterPosition) { | ||
| super(values, mapping, comment, recordNumber, characterPosition); | ||
| } | ||
|
|
||
| @Override | ||
| public CSVMutableRecord withValue(int index, String value) { | ||
| super.put(index, value); | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public CSVMutableRecord withValue(String name, String value) { | ||
| super.put(name, value); | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public CSVRecord withComment(String comment) { | ||
| this.comment = comment; | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| boolean isMutable() { | ||
| return true; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am considering if there's not much point in the
CSVMutableRecordclass anymore, except in any hope of the compiler being clever due to the final methods and the inlineisMutable()constant.An alternative is to add a
private final boolean mutabletoCSVRecordand make it final again - a variant of #21 from @nmahendru.