Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new key to control reattach disk to vm #97

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

vishesh92
Copy link
Member

Fixes #72

@vishesh92 vishesh92 added this to the v0.5.0 milestone Mar 7, 2024
@vishesh92 vishesh92 changed the title Add new key to control reatch disk to vm Add new key to control reattach disk to vm Mar 7, 2024
Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM didn't test it

Copy link
Collaborator

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested it manually and, the resize operation happened without any detach of the disk

  # cloudstack_disk.test-disk will be updated in-place
  ~ resource "cloudstack_disk" "test-disk" {
        id                 = "9d87be3a-1199-4cee-b491-3ef4edbec428"
        name               = "test-disk"
      ~ size               = 15 -> 20
        tags               = {}
        # (7 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Screenshot 2024-03-11 at 1 42 50 PM

@vishesh92 vishesh92 merged commit 9b1501e into apache:main Mar 11, 2024
1 of 4 checks passed
@vishesh92 vishesh92 deleted the reattach-disk-on-change branch March 11, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support hot resize of disk
3 participants