Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service and disk offerings #77

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

service and disk offerings #77

wants to merge 2 commits into from

Conversation

poddm
Copy link
Contributor

@poddm poddm commented Jan 4, 2024

Enhanced the following resources to support the full api spec.

  • cloudstack_disk_offering
  • cloudstack_service_offering_constrained
  • cloudstack_service_offering_unconstrained
  • cloudstack_service_offering_fixed

I split the service offering API up into multiple resources to make it a bit clearer of the different qos types

@rohityadavcloud rohityadavcloud added this to the v0.5.0 milestone Jan 30, 2024
@adidiborg
Copy link

Hi @rohityadavcloud, any tentative timelines when v0.5.0 would release? Already merged features could be of a lot of use 😄

@rohityadavcloud
Copy link
Member

Hi @adidiborg welcome to the opensource project, I hear you and I hope the community can work towards a release soon. I hope the next TF release will be sometime in coming months.

Anybody in the community can work to become a committer and PMC member, and lead release work who work in their "free" time, and it's highly encouraged that users and organisations participate and sponsor their team to work in the community. It's often seen many interested individuals and organisations come together to work on their features and sometimes releases, and often some organisations sponsor feature and maintenance work, and collaborate for testing and release work but not just limited to coding but also documentation, website, marketing and events.

Everyone is welcome to start discussions on our dev@ and users@ mailing lists, in fact your comment would be more visible on the lists unless it was only specifically for me.

@adidiborg
Copy link

Hi @adidiborg welcome to the opensource project, I hear you and I hope the community can work towards a release soon. I hope the next TF release will be sometime in coming months.

Anybody in the community can work to become a committer and PMC member, and lead release work who work in their "free" time, and it's highly encouraged that users and organisations participate and sponsor their team to work in the community. It's often seen many interested individuals and organisations come together to work on their features and sometimes releases, and often some organisations sponsor feature and maintenance work, and collaborate for testing and release work but not just limited to coding but also documentation, website, marketing and events.

Everyone is welcome to start discussions on our dev@ and users@ mailing lists, in fact your comment would be more visible on the lists unless it was only specifically for me.

thanks for responding, I will also try to contribute whereever I can

@poddm
Copy link
Contributor Author

poddm commented Apr 26, 2024

Update - I'd still like to get these merged once the cloudstack SDK is updated.

@rohityadavcloud
Copy link
Member

@poddm can you address conflicts on your PR?

@CodeBleu
Copy link
Collaborator

CodeBleu commented Aug 14, 2024

@fabiomatavelli @kiranchavala @poddm Can we come to an agreement on service_offerings between this PR and what @fabiomatavelli had worked on here #113 and move forward with one of these solutions? This is starting to become an issue for me to be able to manage service offerings for our customers and this would be a huge help to be able to create less offerings because of being able to have offerings that are more dynamic to use.

P.S. @kiranchavala I would like to see a new release this quarter (end of Aug would be nice 😄 ) What can we do to help move the release of a version?

cc: @rohityadavcloud

@poddm
Copy link
Contributor Author

poddm commented Aug 14, 2024

I can remove cloudstack_disk_offering to not conflict with the other changes.

I'd like to keep the separate types to align the GUI presentation and make it easier to understand what fields are required.

  • cloudstack_service_offering_constrained
  • cloudstack_service_offering_unconstrained
  • cloudstack_service_offering_fixed

@rohityadavcloud
Copy link
Member

@poddm @fabiomatavelli I was on vacation so couldn't reply earlier.

Longer term, since you're both active contributors and if you want to main and drive releases yourselves I can propose you both as committers after which you can propose yourself to be release managers (did some write up here on the typical release process: https://cwiki.apache.org/confluence/display/CLOUDSTACK/%5BDRAFT%5D+How+to+Become+a+CloudStack+Release+Manager ) - let me know if you're interested to do that.

Looking at $dayjob pile and on-going community work, I think most of us will busy this/next month working towards the upcoming ACS 4.20 and other misc releases. We'll be available most likely in end of Q3 or in Q4 for the next ACS Terraform (Tofu) Provider releases.

Meanwhile, feel free to work on stabilising the PRs & overall main branch to be ready for release work and continue to build/use the snapshots as required. I've pinged @kiranchavala @vishesh92 who can assist with review related queries.

@poddm
Copy link
Contributor Author

poddm commented Aug 22, 2024

@rohityadavcloud, I'm interested.

@vishesh92
Copy link
Member

@poddm The build is failing. Please check.
Also, I am not sure about removing existing resource types. This can cause issues for users during an upgrade. I haven't completely checked, but the end user who will be upgrading the provider will have to migrate his existing terraform setup.

@CodeBleu
Copy link
Collaborator

@poddm The build is failing. Please check. Also, I am not sure about removing existing resource types. This can cause issues for users during an upgrade. I haven't completely checked, but the end user who will be upgrading the provider will have to migrate his existing terraform setup.

@vishesh92 I don't believe the comment about "removing existing resource types" is what you think. I understood it to mean he would remove his changes in this PR that are not related to the "service offerings" resource.

Also, @poddm if we are moving forward with your approach, can we use the new terraform plugin framework approach? #113 I think we should start moving to using that for new/updated resources. Then eventually we can get to upgrading the rest to use the new framework.

@CodeBleu
Copy link
Collaborator

@poddm The build is failing. Please check. Also, I am not sure about removing existing resource types. This can cause issues for users during an upgrade. I haven't completely checked, but the end user who will be upgrading the provider will have to migrate his existing terraform setup.

@vishesh92 I don't believe the comment about "removing existing resource types" is what you think. I understood it to mean he would remove his changes in this PR that are not related to the "service offerings" resource.

Also, @poddm if we are moving forward with your approach, can we use the new terraform plugin framework approach? #113 I think we should start moving to using that for new/updated resources. Then eventually we can get to upgrading the rest to use the new framework.

@poddm @vishesh92 @rohityadavcloud

Is there anything I can help with to get this merged? I'm desperately needing to have this avail, so I can pass this on to our customers and help reduce a lot of manual management of service offerings.

@poddm
Copy link
Contributor Author

poddm commented Sep 13, 2024

I missed these previous messages. Let me look at refactoring this into the new framework SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants