Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves service offering resource #64

Merged
merged 11 commits into from
Mar 6, 2024

Conversation

fabiomatavelli
Copy link
Collaborator

Hi,

Here is some improvement in the cloudstack_service_offering resource so we can specify the cpu_number, cpu_speed and memory now.

I've added the acceptance test CI which can be run with different versions of Cloudstack. Although it is failing, the specific test for this change is passing:

=== RUN   TestAccCloudStackServiceOffering_basic
--- PASS: TestAccCloudStackServiceOffering_basic (0.33s)

Also, I made a change in the README to include the updated version of the cloudstack-simulator.

@fabiomatavelli fabiomatavelli marked this pull request as ready for review August 4, 2023 15:41
@rohityadavcloud rohityadavcloud added this to the v0.5.0 milestone Aug 4, 2023
Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM didn't test it though; let's see how the github actions behave

@rohityadavcloud
Copy link
Member

@fabiomatavelli thank you for the PR. I liked how you've introduce a CI github action. There is a conflict with README, could you help resolve it.

@fabiomatavelli
Copy link
Collaborator Author

fabiomatavelli commented Aug 4, 2023

changes applied @rohityadavcloud, I think you'll need to approve it again

@rohityadavcloud
Copy link
Member

Thanks @fabiomatavelli re-running github actions

@fabiomatavelli fabiomatavelli mentioned this pull request Aug 14, 2023
@rohityadavcloud
Copy link
Member

@fabiomatavelli can you help review/resolve the conflict?

@fabiomatavelli
Copy link
Collaborator Author

done @rohityadavcloud

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@vishesh92 vishesh92 merged commit e62e4d4 into apache:main Mar 6, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants