Feature/vapp properties added #62
Conversation
Z-eeshan
commented
Jun 6, 2023
Z-eeshan
commented
- This PR adds vApp Properties field for VMWare related configs and also nicnetworklist paramters from Cloudstack API
- Also code on main branch is not compilble due to an extra argument passed to one of the function's of code. This PR also resolves that.
|
Thanks for the PR @Z-eeshan I've pinged a few contributors to review. |
|
@Z-eeshan can you check the build failures? (probably a go fmt fix?) |
Sure will redo it. Although I had actually ran go fmt and also compiled the binary and tested the features. But will rerun gofmt and recheck the pipeline. |
|
@rohityadavcloud Fixed the issue, I was running an older version of go and missed this fmt issue in the first compilation. I have compiled and tested the code now with the version in the pipeline. |
|
@Pearl1594 @DaanHoogland @harikrishna-patnala would really appreciate if one of you could merge this in. We'd would be using cloudstack for our usecase with terraform so any shortcoming or missing features would be added and I'll try to actively contribute to it. |
- This PR adds vApp Properties field for VMWare related configs and also nicnetworklist paramters from Cloudstack API - Also code on main branch is not compilble due to an extra argument passed to one of the function's of code. This PR also resolves that. Co-authored-by: Zeeshan Saeed <[email protected]>
