Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build Error - Too Many Arguments #60

Closed
wants to merge 2 commits into from
Closed

Conversation

FarnazBGH
Copy link

Fix the "too many arguments in the call to cs.NetworkOffering.NewCreateNetworkOfferingParams" error by ensuring that the function call at line 65 in cloudstack/resource_cloudstack_network_offering.go includes only the required four-string arguments.
Error is:

cloudstack/resource_cloudstack_network_offering.go:65:104: too many arguments in call to cs.NetworkOffering.NewCreateNetworkOfferingParams
	have (string, string, string, []string, string)
	want (string, string, string, string)
make: *** [build] Error 2

@rohityadavcloud
Copy link
Member

Thanks for the PR @FarnazBGH I still see the error from the CI:

make: *** [GNUmakefile:32: fmtcheck] Error 1
gofmt needs running on the following files:
./cloudstack/data_source_cloudstack_instance_test.go
You can use the command: `make fmt` to reformat code.
Error: Process completed with exit code 2.

@FarnazBGH
Copy link
Author

FarnazBGH commented Jun 12, 2023

@rohityadavcloud It should be fixed by my new change.

@rohityadavcloud
Copy link
Member

Same changes are in https://github.com/apache/cloudstack-terraform-provider/pull/62/files, pl check if the build is fixed now. cc @FarnazBGH thanks for the PR, pl re-open or send a new one if there's still any build regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants