note on affinity in combination with vmware DRS #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a note warning users that enabling VMware DRS can conflict with CloudStack affinity definitions, since CloudStack does not leverage VMware’s DRS feature.
- Inserted a
.. note::block explaining DRS unpredictability with VMware. - Clarified that VMware is unaware of CloudStack affinity groups and may override desired placements.
Comments suppressed due to low confidence (1)
source/adminguide/virtual_machines.rst:821
- [nitpick] Consider clarifying what 'undesired configuration' means or linking to the affinity-group section for more context.
may go against the desired configuration.
Comment on lines
+817
to
+819
| .. note:: When using Vmware and enabling DRS, the results are | ||
| unpredictable. Vmware implements similar functionality but | ||
| CloudStack does not leverage the Vmware feature. As Vmware is |
There was a problem hiding this comment.
The vendor name 'VMware' should be capitalized consistently.
Suggested change
| .. note:: When using Vmware and enabling DRS, the results are | |
| unpredictable. Vmware implements similar functionality but | |
| CloudStack does not leverage the Vmware feature. As Vmware is | |
| .. note:: When using VMware and enabling DRS, the results are | |
| unpredictable. VMware implements similar functionality but | |
| CloudStack does not leverage the VMware feature. As VMware is |
Copilot uses AI. Check for mistakes.
Comment on lines
+817
to
+819
| .. note:: When using Vmware and enabling DRS, the results are | ||
| unpredictable. Vmware implements similar functionality but | ||
| CloudStack does not leverage the Vmware feature. As Vmware is |
There was a problem hiding this comment.
Please capitalize 'VMware' as it is a proper product name.
Suggested change
| .. note:: When using Vmware and enabling DRS, the results are | |
| unpredictable. Vmware implements similar functionality but | |
| CloudStack does not leverage the Vmware feature. As Vmware is | |
| .. note:: When using VMware and enabling DRS, the results are | |
| unpredictable. VMware implements similar functionality but | |
| CloudStack does not leverage the VMware feature. As VMware is |
Copilot uses AI. Check for mistakes.
Comment on lines
+817
to
+819
| .. note:: When using Vmware and enabling DRS, the results are | ||
| unpredictable. Vmware implements similar functionality but | ||
| CloudStack does not leverage the Vmware feature. As Vmware is |
There was a problem hiding this comment.
Change both instances of 'Vmware' to 'VMware' for consistency.
Suggested change
| .. note:: When using Vmware and enabling DRS, the results are | |
| unpredictable. Vmware implements similar functionality but | |
| CloudStack does not leverage the Vmware feature. As Vmware is | |
| .. note:: When using VMware and enabling DRS, the results are | |
| unpredictable. VMware implements similar functionality but | |
| CloudStack does not leverage the VMware feature. As VMware is |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: apache/cloudstack#5046
📚 Documentation preview 📚: https://cloudstack-documentation--527.org.readthedocs.build/en/527/