CASSJAVA-102: Fix revapi surious complaints about optional dependencies #2042
+36
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example error: [ERROR] Failed to execute goal org.revapi:revapi-maven-plugin:0.15.1:check (default) on project java-driver-core: The following API problems caused the build to fail: [ERROR] java.field.enumConstantOrderChanged: field com.datastax.oss.driver.api.core.config.DefaultDriverOption.ADDRESS_TRANSLATOR_CLASS: The enum constant was defined on position 61 but is now on 62. The user code can break if it relies on the return value of the "ordinal()" method. https://revapi.org/revapi-java/differences.html#java.field.enumConstantOrderChanged ...
This reverts commit b87a112.
…arargParameter is enabled [ERROR] Failed to execute goal org.revapi:revapi-maven-plugin:0.15.1:check (default) on project java-driver-query-builder: The following API problems caused the build to fail: [ERROR] java.method.varargOverloadsOnlyDifferInVarargParameter: method com.datastax.dse.driver.api.querybuilder.schema.AlterDseTableDropColumnEnd com.datastax.dse.driver.api.querybuilder.schema.AlterDseTableDropColumn::dropColumns(com.datastax.oss.driver.api.core.CqlIdentifier[]): Method only differs in the vararg type from some of its overloads: [method com.datastax.dse.driver.api.querybuilder.schema.AlterDseTableDropColumnEnd com.datastax.dse.driver.api.querybuilder.schema.AlterDseTableDropColumn::dropColumns(java.lang.String[])]. https://revapi.org/revapi-java/differences.html#java.method.varargOverloadsOnlyDifferInVarargParameter [ERROR] java.method.varargOverloadsOnlyDifferInVarargParameter: method com.datastax.dse.driver.api.querybuilder.schema.AlterDseTableDropColumnEnd com.datastax.dse.driver.api.querybuilder.schema.AlterDseTableDropColumn::dropColumns(java.lang.String[]): Method only differs in the vararg type from some of its overloads: [method com.datastax.dse.driver.api.querybuilder.schema.AlterDseTableDropColumnEnd com.datastax.dse.driver.api.querybuilder.schema.AlterDseTableDropColumn::dropColumns(com.datastax.oss.driver.api.core.CqlIdentifier[])]. https://revapi.org/revapi-java/differences.html#java.method.varargOverloadsOnlyDifferInVarargParameter [ERROR] java.method.varargOverloadsOnlyDifferInVarargParameter: method com.datastax.oss.driver.api.querybuilder.relation.MultiColumnRelationBuilder<SelfT> com.datastax.oss.driver.api.querybuilder.relation.OngoingWhereClause<SelfT extends com.datastax.oss.driver.api.querybuilder.relation.OngoingWhereClause<SelfT>>::whereColumns(com.datastax.oss.driver.api.core.CqlIdentifier[]): Method only differs in the vararg type from some of its overloads: [method com.datastax.oss.driver.api.querybuilder.relation.MultiColumnRelationBuilder<SelfT> com.datastax.oss.driver.api.querybuilder.relation.OngoingWhereClause<SelfT extends com.datastax.oss.driver.api.querybuilder.relation.OngoingWhereClause<SelfT>>::whereColumns(java.lang.String[])]. https://revapi.org/revapi-java/differences.html#java.method.varargOverloadsOnlyDifferInVarargParameter
|
I can confirm the following:
At this point my only hesitation involves the increase in the required Maven version to build with this change. I thought we either (a) enforced that somewhere in the pom files or (b) specified it in documentation somewhere... but at the moment I can't find it in either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CASSJAVA-102